Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-4659 golang race detected when closing listener socket #1645

Merged
merged 1 commit into from Dec 11, 2018
Merged

THRIFT-4659 golang race detected when closing listener socket #1645

merged 1 commit into from Dec 11, 2018

Conversation

jgheewala
Copy link
Contributor

Some helpful tips for a successful Apache Thrift PR:

  • Did you test your changes locally or using CI in your fork?
    Tested changes locally
  • Is the Apache Jira THRIFT ticket identifier in the PR title?
    Yes
  • Is the Apache Jira THRIFT ticket identifier in the commit message?
    Yes
  • Did you squash your changes to a single commit?
    Yes
  • Are these changes backwards compatible? (please say so in PR description)
  • Do you need to update the language-specific README?

Client: [go]

@dcelasun dcelasun merged commit 2b7365c into apache:master Dec 11, 2018
hsanjuan pushed a commit to gxed/thrift-go that referenced this pull request Jan 30, 2019
@jgheewala @dcelasun
THRIFT-4659: Fix race when closing server socket (apache#1645)
c4de196 
Client: go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeking3 jeking3 jeking3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jgheewala @jeking3 @dcelasun