Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to save report due to Add button not enable #28149

Open
2 of 3 tasks
badf007 opened this issue Apr 19, 2024 · 9 comments
Open
2 of 3 tasks

Unable to save report due to Add button not enable #28149

badf007 opened this issue Apr 19, 2024 · 9 comments
Assignees

Comments

@badf007
Copy link

badf007 commented Apr 19, 2024

Bug description

While filling in all the required information there is still an error in the Notification method section where it shows that a recipient is missing even when valid emails are provided.

How to reproduce the bug

  1. Go to alerts and reports.
  2. Go to the report section
  3. Click Add report
  4. Fill all required fields.

What should happen:

  • The ADD button is enabled and the report can be saved

What is happening:

  • The ADD button is not enabled and a red asterisk is shown in the EMAIL RECIPIENTS field.

Screenshots/recordings

image

image

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@cmartinezdnn
Copy link

Same issue happening to me. It looks like there is bug in new superset 4.0 version.

@sfirke
Copy link
Contributor

sfirke commented May 8, 2024

Someone in Slack is seeing this too. I am running 4.0.0 in production and can successfully create a new alert, so this is not universally broken. My best guess is that there's something in the recipients validation checker that succeeds on my instance but fails for these people without telling them why. CC @fisjac as I believe they wrote some of this new validation.

@alexkyurtev
Copy link

please contact me if further information is needed , i`m also seeing this bug on my side

@fisjac
Copy link
Contributor

fisjac commented May 8, 2024

Looking into this.

@padbk
Copy link

padbk commented May 13, 2024

I am also seeing this issue, it is preventing our upgrade to 4.0.0 and is it not fixed in 4.0.1rc1

@michael-s-molina Could you help to get the above PR merged and included in 4.0.1 please? 🙏

@square-li
Copy link

+1 also having this issue with 4.0. Thanks!

@rusackas
Copy link
Member

4.0.1 has been voted in... so this could become part of 4.0.2, coming soon. If you want to test/vote on these release candidates officially, please do join the dev@superset.apache.org email list (let me know if you want instructions).

Normally we close issues with the PR that fixes them is merged to master. If that's the case here, we should close this, and the fix will be destined for the next release. Any objections?

@adimyth
Copy link

adimyth commented May 16, 2024

@rusackas I checked the release-announcements channel & other relevant channels on slack, but couldn't find a tentative timeline for 4.0.2 release

Any idea when would it be released?

PS - @fisjac thanks for fixing this 👍

@michael-s-molina
Copy link
Member

Hi @adimyth. We generally try to release a patch every month. We just released 4.0.1 on Monday so 4.0.2 will probably be released mid June. @eschutho @sadpandajoe are working on 4.1 but I don't know if it will be released sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests