jenkins matrix 1.8 #299
Merged
jenkins matrix 1.8 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes Jenkinsfile's adds .jenkins.groovy
bmarwell
requested changes
May 7, 2021
fpapon
approved these changes
May 8, 2021
bmarwell
approved these changes
May 10, 2021
bmarwell
requested changes
May 10, 2021
.jenkins.groovy
Outdated
Comment on lines
39
to
41
| values 'jdk_1.8_latest', | ||
| 'jdk_11_latest', | ||
| 'jdk_16_latest' |
There was a problem hiding this comment.
Currently in main:
Lines 39 to 41 in 4cebebb
Suggested change
| values 'jdk_1.8_latest', | |
| 'jdk_11_latest', | |
| 'jdk_16_latest' | |
| values 'jdk_1.8_latest', 'adopt_hs_8_latest', 'adopt_j9_8_latest', | |
| 'jdk_11_latest', 'adopt_hs_11_latest', 'adopt_j9_11_latest', | |
| 'jdk_16_latest', 'adopt_hs_16_latest', 'adopt_j9_16_latest' | |
There was a problem hiding this comment.
The maven bundle plugin doesn't build with 16, and there are some groovy compatibility issues too.
I think it's worth building up to Java 14 (there was a crypto alias change) for the time being on this branch, and keep main building on 8, 11, and the last release (16 atm).
Thoughts?
There was a problem hiding this comment.
Ok, I think we can keep 14 for now.
There are a few issues with the maven plugins used in the 1.8.x branch, these issues have been resolved on `main`, and should be merged in a different PR (if they need to be back ported)
bmarwell
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.