Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-736] default to PaddingScheme.NONE when using GCM #194

Merged
merged 1 commit into from Jan 30, 2020
Merged

[SHIRO-736] default to PaddingScheme.NONE when using GCM #194

merged 1 commit into from Jan 30, 2020

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Jan 14, 2020

Issue: https://issues.apache.org/jira/browse/SHIRO-736

AES/GCM/PKCS5Padding is an alias for AES/GCM/NoPadding on most JVMs. Some JVMs do not have this alias defined, which results in an Exception with the default configuration.

org.apache.shiro.crypto.CryptoException: Unable to acquire a Java JCA Cipher instance using javax.crypto.Cipher.getInstance( "AES/GCM/PKCS5Padding" ). AES under this configuration is required for the org.apache.shiro.crypto.AesCipherService instance to function.
Caused by: java.security.NoSuchAlgorithmException: Cannot find any provider supporting AES/GCM/PKCS5Padding
  at javax.crypto.Cipher.getInstance(Unknown Source)
  at org.apache.shiro.crypto.JcaCipherService.newCipherInstance(JcaCipherService.java:408)

@bmarwell
Copy link
Contributor Author

Before merging, maybe get approval of the apache sercurity team?

@bdemers
Copy link
Member

bdemers commented Jan 15, 2020

@bmhm which JVM are you using?
NM, I found your answer on the dev list:

older (Adopt Open / IBM) J9 JVMs

@bmarwell
Copy link
Contributor Author

bmarwell commented Jan 15, 2020

You can download it from wadev central along with liberty profile.

The open source variant is eclipse openj9, which you can get from adoptopenjdk.net.

@bdemers bdemers merged commit 9786f90 into apache:master Jan 30, 2020
@bmarwell bmarwell deleted the SHIRO-736 branch March 11, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants