Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-735] Enable servlet async support. #193

Merged
merged 1 commit into from Jan 16, 2020
Merged

[SHIRO-735] Enable servlet async support. #193

merged 1 commit into from Jan 16, 2020

Conversation

bmarwell
Copy link
Contributor

Enables async support for use of @Suspended AsyncResponse. Some Application Servers, like Liberty Profile, will throw a NullPointerException without this commit.

Signed-off-by: Benjamin Marwell bmarwell@gmail.com

Signed-off-by: Benjamin Marwell <bmarwell@gmail.com>
@fpapon fpapon requested review from bdemers and fpapon January 12, 2020 20:18
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@bmhm thanks for the PR, I will add some tests as we mentioned on the mailing list

@fpapon fpapon merged commit 5799afe into apache:master Jan 16, 2020
@bmarwell bmarwell deleted the SHIRO-735 branch January 16, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants