Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIRO-734] Remove Spring-client sample #192

Merged
merged 1 commit into from Jan 12, 2020
Merged

[SHIRO-734] Remove Spring-client sample #192

merged 1 commit into from Jan 12, 2020

Conversation

fpapon
Copy link
Member

@fpapon fpapon commented Jan 10, 2020

No description provided.

bdemers
bdemers approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Looks like there are a couple of references in the root pom that we might be able to clean up too.

I thought we had references to this project somewhere else to, but I don't see it 🤔

@fpapon
Copy link
Member Author

fpapon commented Jan 10, 2020

@bdemers right, let me check the root pom dependencies

@fpapon
Copy link
Member Author

fpapon commented Jan 10, 2020

@bdemers I found a reference in the samples-spring-mvc

@fpapon
Copy link
Member Author

fpapon commented Jan 12, 2020

@bdemers I made the changes in the spring-mvc sample

bdemers
bdemers reviewed Jan 12, 2020
View reviewed changes
Copy link
Member

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fpapon fpapon merged commit 0b52b2d into apache:master Jan 12, 2020
@fpapon fpapon deleted the SHIRO-734 branch January 12, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemers bdemers bdemers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpapon @bdemers