New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bk version to resolve the BouncyCatle issue #11759
Conversation
--- Fixes apache#10937 *Motivation* The previours bk version was introduce an incompatible issue with BouncyCastle FIPS. BookKeeper already fix this and we should upgrade the version to resolve the issue. For more information: apache#10937 *Modifications* Upgrade bk to 4.14.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zymap license check failed, PTAL |
@@ -446,7 +446,7 @@ The Apache Software License, Version 2.0 | |||
* SnakeYaml -- org.yaml-snakeyaml-1.27.jar | |||
* RocksDB - org.rocksdb-rocksdbjni-6.10.2.jar | |||
* Google Error Prone Annotations - com.google.errorprone-error_prone_annotations-2.5.1.jar | |||
* Apache Thrifth - org.apache.thrift-libthrift-0.12.0.jar | |||
* Apache Thrifth - org.apache.thrift-libthrift-0.14.2.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apache Thrift?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a dependency of DistributedLog, used by the StreamStorage Service, used by Pulsar Functions
Fixes apache#10937 *Motivation* The previours bk version was introduce an incompatible issue with BouncyCastle FIPS. BookKeeper already fix this and we should upgrade the version to resolve the issue. For more information: apache#10937 *Modifications* Upgrade bk to 4.14.2
Fixes apache#10937 *Motivation* The previours bk version was introduce an incompatible issue with BouncyCastle FIPS. BookKeeper already fix this and we should upgrade the version to resolve the issue. For more information: apache#10937 *Modifications* Upgrade bk to 4.14.2
Fixes #10937
Motivation
The previours bk version was introduce an incompatible issue
with BouncyCastle FIPS. BookKeeper already fix this and we
should upgrade the version to resolve the issue.
For more information: #10937
Modifications
Upgrade bk to 4.14.2
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
For contributor
For this PR, do we need to update docs?
If yes, please update docs or create a follow-up issue if you need help.
If no, please explain why.
For committer
For this PR, do we need to update docs?
If yes,
if you update docs in this PR, label this PR with the
doc
label.if you plan to update docs later, label this PR with the
doc-required
label.if you need help on updating docs, create a follow-up issue with the
doc-required
label.If no, label this PR with the
no-need-doc
label and explain why.