Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broker] Call .release() when discarding entry to prevent direct memory leak #11748

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Aug 23, 2021

Motivation

I was reading the source code of org.apache.pulsar.broker.service.persistent.PersistentDispatcherSingleActiveConsumer class and spotted a missing org.apache.bookkeeper.mledger.Entry.release() call.

Modifications

call the .release() method the same way as it's implemented in

@lhotari lhotari added the type/bug The PR fixed a bug or issue reported a bug label Aug 23, 2021
@lhotari lhotari added this to the 2.9.0 milestone Aug 23, 2021
@lhotari lhotari self-assigned this Aug 23, 2021
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch !

@merlimat merlimat merged commit 7906bb5 into apache:master Aug 23, 2021
lhotari added a commit to datastax/pulsar that referenced this pull request Aug 24, 2021
lhotari added a commit to datastax/pulsar that referenced this pull request Aug 24, 2021
hangc0276 pushed a commit that referenced this pull request Aug 25, 2021
@hangc0276 hangc0276 added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Aug 25, 2021
codelipenghui pushed a commit that referenced this pull request Dec 11, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Dec 11, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.7.4 release/2.8.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants