Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all web threads will get stuck when deleting the namespace #11596

Merged
merged 1 commit into from Aug 8, 2021

Conversation

315157973
Copy link
Contributor

Motivation

Since join() does not time out, all threads are blocked here.
image

@315157973 315157973 self-assigned this Aug 8, 2021
@315157973 315157973 added the doc-not-needed Your PR changes do not impact docs label Aug 8, 2021
@codelipenghui codelipenghui added this to the 2.9.0 milestone Aug 8, 2021
@codelipenghui codelipenghui added type/bug The PR fixed a bug or issue reported a bug release/2.8.1 labels Aug 8, 2021
@@ -227,7 +227,8 @@ protected void internalDeleteNamespace(AsyncResponse asyncResponse, boolean auth
boolean isEmpty;
List<String> topics;
try {
topics = pulsar().getNamespaceService().getListOfPersistentTopics(namespaceName).join();
topics = pulsar().getNamespaceService().getListOfPersistentTopics(namespaceName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!
There are many places which call getListOfPersistentTopics also use join to get the CompletableFuture result, would you please fix them? thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll start a new PR and fix all the places where join is used

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eolivelli eolivelli merged commit c4a2572 into apache:master Aug 8, 2021
@315157973
Copy link
Contributor Author

2.7.x will also have this problem, do we need to move it to 2.7.x?

@codelipenghui @eolivelli

@eolivelli
Copy link
Contributor

I am not sure that this patch applies to 2.7.x.

if no user reported this problem it is better to not cherry pick patches to a "stable" branch.

In my opinion we should cherry pick only the strictly needed patches, as far as a branch becomes "old" it is better to port only security related fixes or fixes about consistency or data loss.

The more commits we cherry pick the more likely it is that we make the branch less stable

LeBW pushed a commit to LeBW/pulsar that referenced this pull request Aug 9, 2021
hangc0276 pushed a commit that referenced this pull request Aug 12, 2021
@hangc0276 hangc0276 added cherry-picked/branch-2.8 Archived: 2.8 is end of life area/broker labels Aug 12, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants