Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Fix the flaky test in the ManagedLedgerTest #11016

Merged
merged 1 commit into from Jun 22, 2021
Merged

[Tests] Fix the flaky test in the ManagedLedgerTest #11016

merged 1 commit into from Jun 22, 2021

Conversation

codelipenghui
Copy link
Contributor 

Error:  testExpiredLedgerDeletionAfterManagedLedgerRestart(org.apache.bookkeeper.mledger.impl.ManagedLedgerTest)  Time elapsed: 0.024 s  <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
	at org.testng.Assert.fail(Assert.java:99)
	at org.testng.Assert.failNotEquals(Assert.java:1037)
	at org.testng.Assert.assertTrue(Assert.java:45)
	at org.testng.Assert.assertTrue(Assert.java:55)
	at org.apache.bookkeeper.mledger.impl.ManagedLedgerTest.testExpiredLedgerDeletionAfterManagedLedgerRestart(ManagedLedgerTest.java:2954)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

@codelipenghui
Fix the flaky test in the ManagedLedgerTest
e180164 
```
Error:  testExpiredLedgerDeletionAfterManagedLedgerRestart(org.apache.bookkeeper.mledger.impl.ManagedLedgerTest)  Time elapsed: 0.024 s  <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
	at org.testng.Assert.fail(Assert.java:99)
	at org.testng.Assert.failNotEquals(Assert.java:1037)
	at org.testng.Assert.assertTrue(Assert.java:45)
	at org.testng.Assert.assertTrue(Assert.java:55)
	at org.apache.bookkeeper.mledger.impl.ManagedLedgerTest.testExpiredLedgerDeletionAfterManagedLedgerRestart(ManagedLedgerTest.java:2954)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
```
@codelipenghui codelipenghui self-assigned this Jun 22, 2021
@codelipenghui codelipenghui added this to the 2.9.0 milestone Jun 22, 2021
@lhotari lhotari merged commit 1623790 into apache:master Jun 22, 2021
eolivelli pushed a commit to datastax/pulsar that referenced this pull request Jun 22, 2021
@codelipenghui @eolivelli
Fix the flaky test in the ManagedLedgerTest (apache#11016)
a1bbce8 
fixes testExpiredLedgerDeletionAfterManagedLedgerRestart

(cherry picked from commit 1623790)
eolivelli pushed a commit that referenced this pull request Jun 22, 2021
@codelipenghui @eolivelli
Fix the flaky test in the ManagedLedgerTest (#11016)
a9b49ef 
fixes testExpiredLedgerDeletionAfterManagedLedgerRestart

(cherry picked from commit 1623790)
@eolivelli eolivelli added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jun 22, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
@codelipenghui @yangl
Fix the flaky test in the ManagedLedgerTest (apache#11016)
eaa7f18 
fixes testExpiredLedgerDeletionAfterManagedLedgerRestart
@mattisonchao mattisonchao mentioned this pull request Jun 24, 2021
Closed
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@codelipenghui @ciaocloud
Fix the flaky test in the ManagedLedgerTest (apache#11016)
41bef84 
fixes testExpiredLedgerDeletionAfterManagedLedgerRestart
@codelipenghui codelipenghui deleted the penghui/fix-ML-flaky-test branch May 17, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari approved these changes

@hangc0276 hangc0276 hangc0276 approved these changes

@315157973 315157973 315157973 approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@congbobo184 congbobo184 Awaiting requested review from congbobo184

@eolivelli eolivelli Awaiting requested review from eolivelli

@gaoran10 gaoran10 Awaiting requested review from gaoran10

@sijie sijie Awaiting requested review from sijie

Assignees

@codelipenghui codelipenghui

Labels
area/test cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.1 type/flaky-tests
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@codelipenghui @lhotari @hangc0276 @315157973 @eolivelli