Make MetadataCacheTest reliable. #10877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid issue due to async update by using Awaitility
|
@lhotari: can you please help with the review |
|
LGTM. |
merlimat
approved these changes
Jun 9, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
Avoid issue due to async update by using Awaitility Co-authored-by: Surinder Singh <surinders@splunk.com>
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 12, 2021
Avoid issue due to async update by using Awaitility Co-authored-by: Surinder Singh <surinders@splunk.com> (cherry picked from commit 4cf1008)
hangc0276
pushed a commit
that referenced
this pull request
Aug 25, 2021
Avoid issue due to async update by using Awaitility Co-authored-by: Surinder Singh <surinders@splunk.com> (cherry picked from commit 4cf1008)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Avoid issue due to async update by using Awaitility Co-authored-by: Surinder Singh <surinders@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10872
Motivation
Cache updates are asynchronous. Due to this the test could sometime fail. This makes the test flaky
MetadataCacheTest
Modifications
Use Awaitility module to more reliably check for the test conditions
Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
A simple bugfix in test code. Doen't need any doc updates