[broker] Add REST API to enable or disable replicated subscriptions #10790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massakam
added
type/enhancement
codelipenghui
requested review from
eolivelli,
merlimat,
315157973,
gaoran10,
hangc0276,
zymap and
congbobo184
315157973
reviewed
Jun 3, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
codelipenghui
approved these changes
Jun 4, 2021
eolivelli
requested changes
Jun 4, 2021
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Outdated
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorSubscriptionTest.java
Show resolved
Hide resolved
massakam
changed the title
added 7 commits
June 9, 2021 11:18
…included in the replication clusters
massakam
force-pushed
the
disable-repl-sub
branch
from
d6fa74b
to
b5ee9db
Compare
massakam
changed the title
|
@eolivelli PTAL |
eolivelli
requested changes
Jun 9, 2021
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Show resolved
Hide resolved
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Outdated
Show resolved
Hide resolved
massakam
force-pushed
the
disable-repl-sub
branch
from
0dc734e
to
02487e1
Compare
|
@eolivelli PTAL |
eolivelli
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
LGTM
@codelipenghui do you want to take another look ?
the patch changed a little since your review
|
@codelipenghui @MarvinCai Can you review this PR? |
nkurihar
approved these changes
Jun 24, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 7, 2021
…10790) ### Motivation Currently, once a replicated subscription is created on a topic, there is no way for users to disable it. I think it is useful to have a REST API that allows users to enable or disable replicated subscriptions. ### Modifications Added the following REST API endpoints: ``` /admin/persistent/{tenant}/{cluster}/{namespace}/{topic}/subscription/{subName}/replicatedSubscriptionStatus /admin/v2/persistent/{tenant}/{namespace}/{topic}/subscription/{subName}/replicatedSubscriptionStatus ``` We can enable/disable a replicated subscription by posting true or false to these endpoints. (cherry picked from commit 1d3e92e)
codelipenghui
pushed a commit
that referenced
this pull request
Aug 13, 2021
### Motivation The test `testSetReplicatedSubscriptionStatus ` add by #10790, and the code `persistentTopics.createPartitionedTopic(response, testTenant, testNamespace, topicName, 2, true);` `createLocalTopicOnly` set `true`. However, when the PR cherry-pick to branch-2.8, this commit `https://github.com/apache/pulsar/commit/0706bc01a428a9405c671a0f80fb54faccdd26e6`, which lead the test run failed.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…pache#10790) ### Motivation Currently, once a replicated subscription is created on a topic, there is no way for users to disable it. I think it is useful to have a REST API that allows users to enable or disable replicated subscriptions. ### Modifications Added the following REST API endpoints: ``` /admin/persistent/{tenant}/{cluster}/{namespace}/{topic}/subscription/{subName}/replicatedSubscriptionStatus /admin/v2/persistent/{tenant}/{namespace}/{topic}/subscription/{subName}/replicatedSubscriptionStatus ``` We can enable/disable a replicated subscription by posting true or false to these endpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, once a replicated subscription is created on a topic, there is no way for users to disable it. I think it is useful to have a REST API that allows users to enable or disable replicated subscriptions.
Modifications
Added the following REST API endpoints:
We can enable/disable a replicated subscription by posting true or false to these endpoints.