Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #6841]fix autoSkipConf #6863

Merged
merged 2 commits into from May 12, 2020
Merged

[Issue #6841]fix autoSkipConf #6863

merged 2 commits into from May 12, 2020

Conversation

pheecian
Copy link
Contributor

@pheecian pheecian commented May 2, 2020

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #6841

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codelipenghui codelipenghui added release/2.5.2 type/bug The PR fixed a bug or issue reported a bug labels May 6, 2020
@codelipenghui codelipenghui added this to the 2.6.0 milestone May 6, 2020
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

1 similar comment
@sijie
Copy link
Member

sijie commented May 7, 2020

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented May 11, 2020

/pulsarbot run-failure-checks

4 similar comments
@jiazhai
Copy link
Member

jiazhai commented May 11, 2020

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented May 12, 2020

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented May 12, 2020

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented May 12, 2020

/pulsarbot run-failure-checks

@jiazhai jiazhai merged commit 3198f4f into apache:master May 12, 2020
jiazhai pushed a commit that referenced this pull request May 12, 2020
Fixes #6841
Co-authored-by: Xiaopeng Zhang <xiaopengzhang@Xiaopengs-MacBook-Pro.local>
Co-authored-by: Jia Zhai <zhaijia@apache.org>
(cherry picked from commit 3198f4f)
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request May 27, 2020
Fixes apache#6841
Co-authored-by: Xiaopeng Zhang <xiaopengzhang@Xiaopengs-MacBook-Pro.local>
Co-authored-by: Jia Zhai <zhaijia@apache.org>
addisonj pushed a commit to instructure/pulsar that referenced this pull request Jun 12, 2020
Fixes apache#6841
Co-authored-by: Xiaopeng Zhang <xiaopengzhang@Xiaopengs-MacBook-Pro.local>
Co-authored-by: Jia Zhai <zhaijia@apache.org>
(cherry picked from commit 3198f4f)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
Fixes apache#6841
Co-authored-by: Xiaopeng Zhang <xiaopengzhang@Xiaopengs-MacBook-Pro.local>
Co-authored-by: Jia Zhai <zhaijia@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2.5.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoSkipNonRecoverableData config in broker.conf does not work
4 participants