Fix pulsar sink and source state #5046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrypeng
added
type/bug
|
Hi @jerrypeng We are planning the 2.4.1 release ,how about mark this as 2.4.2? |
|
rerun cpp tests |
|
@jiazhai I would like to see this fix to be in official release as soon as possible since it impacts users' ability to use a major feature, however I understand that you have started the release process for 2.4.1 a while back and would like to finish it. I will be ok if you want to push this to 2.4.2 release. |
jiazhai
approved these changes
Aug 27, 2019
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
(cherry picked from commit 40d6248)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, state is broken for Pulsar sources and sinks. The reason is because state is initialized after initializing source