Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support in cpp client for 1 partitioned topic #5016

Merged
merged 2 commits into from Aug 26, 2019

Conversation

jiazhai
Copy link
Member

@jiazhai jiazhai commented Aug 22, 2019

Motivation

IN PR #4883, we support 1 partitioned topic producer/consumer in java client. this is for Cpp client support.

Modifications

  • change cpp client
  • add unit test

Verifying this change

New added Ut Passed

@jiazhai jiazhai added this to the 2.4.1 milestone Aug 22, 2019
@jiazhai jiazhai requested review from merlimat and sijie August 22, 2019 13:40
@jiazhai jiazhai self-assigned this Aug 22, 2019
@sijie
Copy link
Member

sijie commented Aug 22, 2019

run cpp tests

@sijie
Copy link
Member

sijie commented Aug 22, 2019

retest this please

@jiazhai
Copy link
Member Author

jiazhai commented Aug 23, 2019

run cpp tests

@jiazhai
Copy link
Member Author

jiazhai commented Aug 25, 2019

run cpp tests
run java8 tests

@sijie
Copy link
Member

sijie commented Aug 25, 2019

run cpp tests

@jiazhai jiazhai merged commit bf94890 into apache:master Aug 26, 2019
jiazhai added a commit that referenced this pull request Aug 28, 2019
### Motivation

IN PR #4883, we support 1 partitioned topic producer/consumer in java client. this is for Cpp client support.

### Modifications
- change cpp client
- add unit test

### Verifying this change
New added Ut Passed

(cherry picked from commit bf94890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants