Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulsar-client-cpp] fix snappy compressor compile error #4972

Merged
merged 1 commit into from Aug 20, 2019
Merged

[pulsar-client-cpp] fix snappy compressor compile error #4972

merged 1 commit into from Aug 20, 2019

Conversation

yittg
Copy link
Contributor

@yittg yittg commented Aug 17, 2019 •
edited

Fixes #4720

Motivation

for now, the snappy compressor can not be compiled successfully,
which raise undeclared identifier and no matching function errors.

Modifications

fix compile errors, use snappy c++ apis.

Verifying this change

  • Make sure that the change passes the CI checks.

libsnappy-dev is installed from Dockerfile, but cmake got HAS_SNAPPY: 0 in CI as outdated docker image, so these codes were not compiled ever in CI.
May we checkout a new build image, apachepulsar/pulsar-build:ubuntu-16.04 has no libsnappy installed.

@sijie sijie modified the milestones: 2.4.1, 2.5.0 Aug 18, 2019
@sijie
Copy link
Member

sijie commented Aug 18, 2019

run cpp tests

@sijie
Copy link
Member

sijie commented Aug 18, 2019

run java8 tests

1 similar comment
@sijie
Copy link
Member

sijie commented Aug 18, 2019

run java8 tests

@yittg yittg force-pushed the fix-snappy-compressor branch 3 times, most recently from 695c127 to 17e5dc2 Compare August 18, 2019 10:22
@yittg
Copy link
Contributor Author

yittg commented Aug 18, 2019

run java8 tests

@sijie sijie merged commit 385a036 into apache:master Aug 20, 2019
@yittg yittg deleted the fix-snappy-compressor branch August 20, 2019 04:09
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
@yittg @jiazhai
[pulsar-client-cpp] fix snappy compressor compile error (#4972)
057e7d2 
Fixes #4720
### Motivation

for now, the snappy compressor can not be compiled successfully,
which raise undeclared identifier and no matching function errors.

### Modifications

fix compile errors, use snappy c++ apis.
(cherry picked from commit 385a036)
@scpeters scpeters mentioned this pull request Sep 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@massakam massakam Awaiting requested review from massakam

@merlimat merlimat Awaiting requested review from merlimat

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

Assignees

@yittg yittg

Labels
area/client
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Compilation errors in pulsar-client-cpp
2 participants
@yittg @sijie