TYPO in C++ client producer method for processing failure case #4808
Assignees
Labels
Comments
|
I may submit my PR later if no any doubt. |
easyfan
added a commit
to easyfan/pulsar
that referenced
this issue
Jul 26, 2019
Merge Request for apache#4808: fix typo in C++ client producer
This was referenced Aug 2, 2019
sijie
pushed a commit
that referenced
this issue
Aug 5, 2019
…ssing failure case, and add corresponding unit test case. (#4873) Definitely, this is a typo. This method is dealing with the Failed Message with the GIVEN result, but not a CERTAIN result. Contribution Checklist #4808 : TYPO in C++ client producer method for processing failure case Add c++ client producer failure message unit test case. UT passed: BatchMessageTest
jiazhai
pushed a commit
that referenced
this issue
Aug 28, 2019
…ssing failure case, and add corresponding unit test case. (#4873) Definitely, this is a typo. This method is dealing with the Failed Message with the GIVEN result, but not a CERTAIN result. Contribution Checklist #4808 : TYPO in C++ client producer method for processing failure case Add c++ client producer failure message unit test case. UT passed: BatchMessageTest (cherry picked from commit b90b4ea)
|
This has been fixed by 4873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Inside file pulsar/pulsar-client-cpp/lib/ProducerImpl.cc, the method:
void ProducerImpl::failPendingMessages(Result result)is designed for processing all the failure cases on publishing messages. As the exact result is given by parameter, so every registered message callback should be invoked with exactly the same result. But actually, In the final line of this method, the given code like this:
BatchMessageContainer::batchMessageCallBack(ResultTimeout, messageContainerListPtr, NULL);Definitely, this a typo, as the method should report the callback with the GIVEN result stat, but not a CERTAIN result stat.
The text was updated successfully, but these errors were encountered: