Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing getSchemaVersion in the client by making it public. #3744

Merged
merged 3 commits into from Mar 4, 2019
Merged

Exposing getSchemaVersion in the client by making it public. #3744

merged 3 commits into from Mar 4, 2019

Conversation

skyrocknroll
Copy link
Contributor

Motivation

Exposing getSchemaVersion in the client by making it public.

Modifications

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: (yes )
  • The schema: (no )
  • The default values of configurations: (no)
  • The wire protocol: ( no)
  • The rest endpoints: ( no)
  • The admin cli options: ( no)
  • Anything that affects deployment: (no )

Documentation

  • Does this pull request introduce a new feature? (yes )
  • If yes, how is the feature documented? ( JavaDocs )

@skyrocknroll
Copy link
Contributor Author

run java8 tests

@sijie sijie added area/client type/feature The PR added a new feature or issue requested a new feature labels Mar 4, 2019
@sijie sijie added this to the 2.4.0 milestone Mar 4, 2019
@sijie
Copy link
Member

sijie commented Mar 4, 2019

run java8 tests

@merlimat merlimat merged commit d847c35 into apache:master Mar 4, 2019
shiv4289 pushed a commit to shiv4289/pulsar that referenced this pull request Apr 1, 2019
@skyrocknroll @shiv4289
Exposing getSchemaVersion in the client by making it public. (apache#…
216dcac 
…3744)

* Exposing getSchemaVersion in the client by making it public.

* Implemented getSchemaVersion in TopicMessageImpl.java

* Changed the release version
@merlimat merlimat mentioned this pull request Apr 2, 2019
Closed
1 task
merlimat pushed a commit that referenced this pull request Apr 2, 2019
@skyrocknroll @merlimat
Exposing getSchemaVersion in the client by making it public. (#3744)
515a55e 
* Exposing getSchemaVersion in the client by making it public.

* Implemented getSchemaVersion in TopicMessageImpl.java

* Changed the release version
@merlimat
Copy link
Contributor

merlimat commented Apr 2, 2019

Merged in 2.3.1 at
515a55e

@merlimat merlimat modified the milestones: 2.4.0, 2.3.1 Apr 2, 2019
@skyrocknroll
Copy link
Contributor Author

Thanks @merlimat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

Assignees

@skyrocknroll skyrocknroll

Labels
area/client type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skyrocknroll @sijie @merlimat