Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ml] Fix topic retention by size #22472

Closed
wants to merge 2 commits into from

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Apr 10, 2024

Fixes: #22473

Motivation

For retention policies, it should be retain/delete the ledgers which were consumed.

But currently, we determine whether to delete a ledger by ledger total size(includes un-cosumed ledgers), it is not reasonable, and leads to deleting all the consumed ledger.

And also, the threshold of backlog quota might be related to this: backlog quota limitation have to less than retention. It doesn't make sense, too.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dao-jun dao-jun added type/bug The PR fixed a bug or issue reported a bug ready-to-test area/ML labels Apr 10, 2024
@dao-jun dao-jun added this to the 3.3.0 milestone Apr 10, 2024
@dao-jun dao-jun self-assigned this Apr 10, 2024
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Apr 10, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 10, 2024
@dao-jun dao-jun removed the doc-required Your PR changes impact docs and you will update later. label Apr 10, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But currently, we determine whether to delete a ledger by ledger total size(includes un-cosumed ledgers), it is not reasonable, and leads to deleting all the consumed ledger.

@dao-jun Please report a separate issue with more details since this seems like a significant change. This might even justify a dev mailing list discussion.

@lhotari
Copy link
Member

lhotari commented Apr 10, 2024

It seems like there's a mailing list thread: https://lists.apache.org/thread/sv0wdyhn16r67hobmymfoor4bnd4d0fp.
In addition to this, please first create an issue with clear details in the issue description.

@dao-jun
Copy link
Member Author

dao-jun commented Apr 10, 2024

It seems like there's a mailing list thread: https://lists.apache.org/thread/sv0wdyhn16r67hobmymfoor4bnd4d0fp. In addition to this, please first create an issue with clear details in the issue description.

OK

@lhotari lhotari dismissed their stale review April 10, 2024 10:40

Issue was created

@dao-jun dao-jun marked this pull request as draft April 10, 2024 15:34
@dao-jun dao-jun closed this Apr 11, 2024
@dao-jun
Copy link
Member Author

dao-jun commented Apr 11, 2024

Close the PR since it is a doc issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ML doc-not-needed Your PR changes do not impact docs ready-to-test type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [ml] Incorrect behavior of Topic Retention Policy
2 participants