Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Entry filters per topic/namespace load and unpack NAR files for each topic created #19361

Closed
1 of 2 tasks
nicoloboschi opened this issue Jan 30, 2023 · 0 comments · Fixed by #19364
Closed
1 of 2 tasks
Labels
type/bug The PR fixed a bug or issue reported a bug

Comments

@nicoloboschi
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Version

Master

Minimal reproduce step

#17153 introduces per topic or per namespace entry filters.
The way it's implemented is not very efficient because every time a new topic is created in the broker, the attached entry filters are searched in the filesystem and unzipped. This operation is cpu intensive and it's a waste of resources, considering topics count order of magnitude.

What did you expect to see?

It'd be better to gather all the existing entry filters at the broker startup and create only one classloader per entry filter.
When the topic is created, the related class loader is ready and the broker only needs to instance a new EntryFilter object, reusing the same classloader.

What did you see instead?

See Minimal reproduce step

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant