New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client]Fix MaxQueueSize semaphore release leak in createOpSendMsg #16915
[fix][client]Fix MaxQueueSize semaphore release leak in createOpSendMsg #16915
Conversation
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerSemaphoreTest.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerSemaphoreTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is a conflict when direct merge this to branch 2.7 |
Please also help to cherry-pick to branch 2.9 |
@mattisonchao ok, I'll cherry-pick it to branch 2.9. |
|
Move |
@Nicklee007 Please provide a correct documentation label for your PR. |
@mattisonchao branch 2.9 cherry-pick PR #16958, PTAL. |
@Nicklee007 Please provide a correct documentation label for your PR. |
Co-authored-by: nicklixinyang <nicklixinyang@didiglobal.com>
Move |
@Nicklee007 Please provide a correct documentation label for your PR. |
…sg (apache#16915) (cherry picked from commit d95f6cf) (cherry picked from commit 70f1a03)
Motivation
Release MaxQueueSize semaphore when invalid message, the related PR #16835 only release the memory usage, but the semaphore also need release in here.
The fixed unit test can reproduce it, which only
enableBatching
can invoke thecreateOpSendMsg
inBatchMessageContainerImpl
.Modifications
Documentation
doc-not-needed
(Please explain why)