Forget to update memory usage when invalid message #16835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoothzj
force-pushed
the
fix-memory-release
branch
from
23203ef
to
7ee709f
Compare
gaozhangmin
reviewed
Jul 28, 2022
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java
Outdated
Show resolved
Hide resolved
codelipenghui
added
release/2.10.2
release/2.9.4
type/bug
1 task
shoothzj
force-pushed
the
fix-memory-release
branch
from
7ee709f
to
615f679
Compare
liudezhi2098
approved these changes
Jul 28, 2022
shoothzj
force-pushed
the
fix-memory-release
branch
from
615f679
to
d13dd57
Compare
Technoboy-
approved these changes
Jul 28, 2022
|
/pulsarbot run-failure-checks |
|
@gaozhangmin Please take the final look. Thanks! |
|
来信已收到，我会尽快查阅，祝你生活愉快。
|
1 task
Gleiphir2769
pushed a commit
to Gleiphir2769/pulsar
that referenced
this pull request
Aug 4, 2022
### Modifications release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. ### Verifying this change - add unit tests for this change ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc
|
@shoothzj Could you please help cherry-pick this PR to branch-2.9? |
|
@shoothzj Please provide a correct documentation label for your PR. |
BewareMyPower
pushed a commit
that referenced
this pull request
Aug 5, 2022
### Modifications release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. ### Verifying this change - add unit tests for this change ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a)
|
@shoothzj Please provide a correct documentation label for your PR. |
codelipenghui
pushed a commit
that referenced
this pull request
Aug 8, 2022
### Modifications release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. ### Verifying this change - add unit tests for this change ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2022
### Modifications release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. ### Verifying this change - add unit tests for this change ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a) (cherry picked from commit 72af22c)
congbobo184
pushed a commit
that referenced
this pull request
Nov 10, 2022
release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. - add unit tests for this change Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a)
congbobo184
pushed a commit
that referenced
this pull request
Dec 1, 2022
release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. - add unit tests for this change Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a)
gaozhangmin
pushed a commit
to gaozhangmin/pulsar
that referenced
this pull request
Apr 6, 2023
release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. - add unit tests for this change Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
release memory usage when invalid message.
Only need to release memory usage here, no need to release semaphore. Both add testcases.
coauthored by @pengxiangrui127.
Verifying this change
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-neededbug fix, no need doc