Skip to content

[broker][monitoring] add message ack rate metric for consumer #15674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 13, 2022

Conversation

tjiuming
Copy link
Contributor

@tjiuming tjiuming commented May 19, 2022

Motivation

Currently, we have dispatch rate metrics but don't have consumer acknowledgment-related metrics.
Which not easy to troubleshoot issues like some consumers stop acknowledging messages.

Having an ack rate metric would be very useful to determine if our consumers are processing messages properly.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • no-need-doc
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-added
    (Docs have been already added)

  • doc-complete

Sorry, something went wrong.

@github-actions
Copy link

@tjiuming:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@tjiuming tjiuming changed the title [broker][monitoring] add message [broker][monitoring] add message ack rate metric for consumer May 19, 2022
@github-actions
Copy link

@tjiuming:Thanks for providing doc info!

@github-actions github-actions bot added doc-required Your PR changes impact docs and you will update later. and removed doc-label-missing labels May 19, 2022
@tjiuming
Copy link
Contributor Author

Tests to be completed.

@mattisonchao mattisonchao added this to the 2.11.0 milestone May 19, 2022
@tjiuming
Copy link
Contributor Author

tjiuming commented Jun 7, 2022

/pulsarbot run-failure-checks

@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@mattisonchao mattisonchao merged commit 88b47e5 into apache:master Jun 13, 2022
codelipenghui pushed a commit that referenced this pull request Jun 13, 2022
@mattisonchao
Copy link
Member

Hi @tjiuming
It looks like many conflicts in branch-2.9. I'm not sure if I missing some dependency PR need to merge before this.
Could you please push a new PR for branch-2.9?

@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Jun 13, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jun 13, 2022
@dave2wave
Copy link
Member

Why is something that is NOT A BUG FIX being cherry picked to 2.9 and 2.8?

If there is any difficulty this is a risky change that might break an old branch.

@michaeljmarshall
Copy link
Member

add message ack rate metric for consumer

@tjiuming - can you please provide more motivation for this addition?

@github-actions github-actions bot added doc-required Your PR changes impact docs and you will update later. and removed doc-complete Your PR changes impact docs and the related docs have been already added. labels Jun 14, 2022
@codelipenghui
Copy link
Contributor

@michaeljmarshall @dave2wave I have updated the motivation of this PR

Currently, we don't have message acknowledgment metrics, which is hard to find the ack-related issues.
With this improvement, users can add alerts and dashboards to the acknowledgment behavior of consumers.
So that they can know if consumers are processing messages properly.

It's not a new feature, just to improve the observability of the acknowledgment.
The metrics and logs can help to find the problem.

And I have mentioned this part on the mailing list https://lists.apache.org/thread/wkm1slrg341kbq7m83nms97df28kl4of
But looks like only @michaeljmarshall and I join the discussion. thanks @michaeljmarshall You have started a valuable discussion. We're a little fuzzy on the cherry-picking, I think we can get a clear cherry-pick criteria on the mailing list.
If the metrics and logs cherry-pick are not acceptable, I think we can discuss the mailing list first. Just based on my previous experience, without the logs and metrics, users are hard to detect problems and collect more context about a BUG. The logs and metrics can help pulsar's developers understand the problem.

@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Jun 14, 2022
@mattisonchao mattisonchao added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Jul 2, 2022
BewareMyPower pushed a commit that referenced this pull request Jul 27, 2022
@BewareMyPower BewareMyPower added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-complete Your PR changes impact docs and the related docs have been already added. release/2.8.4 release/2.9.4 release/2.10.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants