-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[broker][monitoring] add message ack rate metric for consumer #15674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tjiuming:Thanks for your contribution. For this PR, do we need to update docs? |
@tjiuming:Thanks for providing doc info! |
Tests to be completed. |
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TopicStats.java
Show resolved
Hide resolved
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
ae9f32f
to
2cb46eb
Compare
(cherry picked from commit 88b47e5)
Hi @tjiuming |
Why is something that is NOT A BUG FIX being cherry picked to 2.9 and 2.8? If there is any difficulty this is a risky change that might break an old branch. |
@tjiuming - can you please provide more motivation for this addition? |
@michaeljmarshall @dave2wave I have updated the motivation of this PR Currently, we don't have message acknowledgment metrics, which is hard to find the ack-related issues. It's not a new feature, just to improve the observability of the acknowledgment. And I have mentioned this part on the mailing list https://lists.apache.org/thread/wkm1slrg341kbq7m83nms97df28kl4of |
(cherry picked from commit 88b47e5)
Motivation
Currently, we have dispatch rate metrics but don't have consumer acknowledgment-related metrics.
Which not easy to troubleshoot issues like some consumers stop acknowledging messages.
Having an ack rate metric would be very useful to determine if our consumers are processing messages properly.
Verifying this change
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
no-need-doc
(Please explain why)
doc
(Your PR contains doc changes)
doc-added
(Docs have been already added)
doc-complete