Non-persistent topic subscription metrics #13827
Merged
+93
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? |
|
@gaozhangmin:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
gaozhangmin
force-pushed
the
non-persistent-sub-metrics
branch
from
6be5606 to
aca0eec
Compare
|
/pulsarbot run-failure-checks |
gaozhangmin
force-pushed
the
non-persistent-sub-metrics
branch
2 times, most recently
from
339a199 to
a0b89a2
Compare
|
/pulsarbot run-failure-checks |
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 25, 2022
|
@codelipenghui PTAL |
Jason918
reviewed
Feb 9, 2022
...broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
non-persistent-sub-metrics
branch
2 times, most recently
from
c591443 to
bd7c36b
Compare
Jason918
reviewed
Feb 15, 2022
...broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java
Outdated
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java
Outdated
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
non-persistent-sub-metrics
branch
from
5b17d48 to
5d0c142
Compare
congbobo184
dismissed stale reviews from nicoloboschi and zzzming
via
5d0c142
Jason918
approved these changes
Feb 16, 2022
|
@Jason918 Can this pr be merged now? |
eolivelli
approved these changes
Feb 21, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2022
(cherry picked from commit bba4cff)
nicoloboschi
pushed a commit
to nicoloboschi/pulsar
that referenced
this pull request
Mar 1, 2022
### Motivation Non-persistent topic doesn't have subscription metrics ### Modifications Expose a new non-persistent subscription metric: `pulsar_subscription_msg_drop_rate`
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
### Motivation Non-persistent topic doesn't have subscription metrics ### Modifications Expose a new non-persistent subscription metric: `pulsar_subscription_msg_drop_rate`
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 28, 2022
### Motivation Non-persistent topic doesn't have subscription metrics ### Modifications Expose a new non-persistent subscription metric: `pulsar_subscription_msg_drop_rate` (cherry picked from commit d548bc4)
codelipenghui
pushed a commit
that referenced
this pull request
Jun 13, 2022
### Motivation Non-persistent topic doesn't have subscription metrics ### Modifications Expose a new non-persistent subscription metric: `pulsar_subscription_msg_drop_rate` (cherry picked from commit d548bc4)
|
Depends by #15674, so cherry-pick to branch 2.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13645
Motivation
Non-persistent topic doesn't have subscription metrics
Modifications
Expose a new non-persistent subscription metric:
pulsar_subscription_msg_drop_rateVerifying this change
This change added tests and can be verified as follows:
org.apache.pulsar.broker.stats.PrometheusMetricsTest#testNonPersistentSubMetrics
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)