[Java Client] Let producer reconnect for state RegisteringSchema #12781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@congbobo184 - PTAL. This change aligns with your recent change to #12689. |
merlimat
approved these changes
Nov 14, 2021
lhotari
approved these changes
Nov 14, 2021
315157973
approved these changes
Nov 15, 2021
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 15, 2021
…che#12781) Motivation In the Java Client, if a producer is in the RegisteringSchema state, it is a valid state for it to reconnect. Fix the ConnectionHandler to align with this behavior. Modifications Update the isValidStateForReconnection method to return true for state RegisteringSchema. Verifying this change This change is a trivial rework / code cleanup without any test coverage. Does this pull request potentially affect one of the following parts: This update does not contain breaking changes. (cherry picked from commit 8d75eed)
eolivelli
pushed a commit
that referenced
this pull request
Nov 15, 2021
) Motivation In the Java Client, if a producer is in the RegisteringSchema state, it is a valid state for it to reconnect. Fix the ConnectionHandler to align with this behavior. Modifications Update the isValidStateForReconnection method to return true for state RegisteringSchema. Verifying this change This change is a trivial rework / code cleanup without any test coverage. Does this pull request potentially affect one of the following parts: This update does not contain breaking changes. (cherry picked from commit 8d75eed)
codelipenghui
pushed a commit
that referenced
this pull request
Nov 18, 2021
) Motivation In the Java Client, if a producer is in the RegisteringSchema state, it is a valid state for it to reconnect. Fix the ConnectionHandler to align with this behavior. Modifications Update the isValidStateForReconnection method to return true for state RegisteringSchema. Verifying this change This change is a trivial rework / code cleanup without any test coverage. Does this pull request potentially affect one of the following parts: This update does not contain breaking changes. (cherry picked from commit 8d75eed)
codelipenghui
added
cherry-picked/branch-2.8
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…che#12781) Motivation In the Java Client, if a producer is in the RegisteringSchema state, it is a valid state for it to reconnect. Fix the ConnectionHandler to align with this behavior. Modifications Update the isValidStateForReconnection method to return true for state RegisteringSchema. Verifying this change This change is a trivial rework / code cleanup without any test coverage. Does this pull request potentially affect one of the following parts: This update does not contain breaking changes.
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…che#12781) Motivation In the Java Client, if a producer is in the RegisteringSchema state, it is a valid state for it to reconnect. Fix the ConnectionHandler to align with this behavior. Modifications Update the isValidStateForReconnection method to return true for state RegisteringSchema. Verifying this change This change is a trivial rework / code cleanup without any test coverage. Does this pull request potentially affect one of the following parts: This update does not contain breaking changes.
codelipenghui
added
release/2.9.1
cherry-picked/branch-2.9
codelipenghui
added
cherry-picked/branch-2.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the Java Client, if a producer is in the
RegisteringSchemastate, it is a valid state for it to reconnect. Fix theConnectionHandlerto align with this behavior.Modifications
isValidStateForReconnectionmethod to returntruefor stateRegisteringSchema.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
This update does not contain breaking changes.
Documentation
no-need-docThis is an implementation detail, so no need to update any documentation.