From d34a91ac9be27a0f388c78a2e9efb7a1297e33d4 Mon Sep 17 00:00:00 2001 From: Masahiro Sakamoto Date: Tue, 3 Aug 2021 01:22:38 +0900 Subject: [PATCH] Improve error logs in BacklogQuotaManager (#11469) (cherry picked from commit 084eebf77548a58d07f984c067fcd055d82e5afd) --- .../pulsar/broker/service/BacklogQuotaManager.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java index c941b6ce46b2c..fa0d24b12f83b 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java @@ -191,13 +191,13 @@ private void dropBacklogForSizeLimit(PersistentTopic persistentTopic, BacklogQuo } // Skip messages on the slowest consumer if (log.isDebugEnabled()) { - log.debug("Skipping [{}] messages on slowest consumer [{}] having backlog entries : [{}]", - messagesToSkip, slowestConsumer.getName(), entriesInBacklog); + log.debug("[{}] Skipping [{}] messages on slowest consumer [{}] having backlog entries : [{}]", + persistentTopic.getName(), messagesToSkip, slowestConsumer.getName(), entriesInBacklog); } slowestConsumer.skipEntries(messagesToSkip, IndividualDeletedEntries.Include); } catch (Exception e) { - log.error("Error skipping [{}] messages from slowest consumer : [{}]", messagesToSkip, - slowestConsumer.getName()); + log.error("[{}] Error skipping [{}] messages from slowest consumer [{}]", persistentTopic.getName(), + messagesToSkip, slowestConsumer.getName(), e); } // Make sure that unconsumed size is updated every time when we skip the messages. @@ -250,7 +250,7 @@ private void dropBacklogForTimeLimit(PersistentTopic persistentTopic, BacklogQuo ledgerInfo = mLedger.getLedgerInfo(ledgerId).get(); } } catch (Exception e) { - log.error("Error resetting cursor for slowest consumer [{}]: {}", + log.error("[{}] Error resetting cursor for slowest consumer [{}]", persistentTopic.getName(), mLedger.getSlowestConsumer().getName(), e); } }