Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/golang-jwt/jwt to v4 #956

Closed
wants to merge 3 commits into from

Conversation

ItalyPaleAle
Copy link

Motivation

This project depended on the v3 of github.com/golang-jwt/jwt. All new versions of the library are now released with the go.mod-enabled github.com/golang-jwt/jwt/v4 import path (although there are no breaking changes from v3).

This is a security-related library and being on the latest version ensures that any security fix can be applied quickly.

Modifications

Updated the golang-jwt library to v4.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable
  • If a feature is not applicable for documentation, explain why? Internal change only
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@nodece
Copy link
Member

nodece commented Feb 23, 2023

@ItalyPaleAle Any updates?

@ItalyPaleAle
Copy link
Author

@nodece my apologies, I disabled notifications for when CI fails (because I was getting spammed) so I didn't get alerted.

The CI is failing because it's trying to run tests using Go 1.16, but the go.mod file says that the minimum version is 1.18. I don't think it's an issue I can fix here :(

@nodece
Copy link
Member

nodece commented May 11, 2024

Closed by #1214

@nodece nodece closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants