[fix] Reconnection logic and Backoff policy doesn't work correctly #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RobertIndie PTAL |
RobertIndie
reviewed
Mar 29, 2024
There was a problem hiding this comment.
I'm concerned that such breaking changes could significantly impact users. Users would have to implement the new methods introduced by the backoff policy, even if they haven't encountered this issue. Perhaps we could consider including this change in the 1.0 version.
I have initiated a discussion of the Go client 1.0.0: https://lists.apache.org/thread/h022q6nrk23tz2k0qpxjf6j8m1o4qsrt
Yes, I agree with you. |
chinmayb
reviewed
May 29, 2024
| delayReconnectTime = pc.options.backoffPolicy.Next() | ||
| } | ||
| delayReconnectTime = bo.Next() | ||
| totalDelayReconnectTime += delayReconnectTime |
There was a problem hiding this comment.
We also need to reset the delayReconnectTime once connected after several retries in 1699.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1187
Modifications
backoff.goto thebackoffdirectory (because there are circular dependencies, they are not moved to the pulsar directory.)BackOffPolicyinterfaceIsMaxBackoffReached(delayReconnectTime, totalDelayReconnectTime time.Duration) boolThis is a breaking change that modifies the package name and interface name.
Package:
internal->backoffInterface name:
BackoffPolicy->PolicyVerifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation