[feat][schema] Introduce BooleanSchema #1108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
reviewed
Oct 26, 2023
| @@ -178,7 +180,7 @@ func (js *JSONSchema) Decode(data []byte, v interface{}) error { | |||
| } | |||
|
|
|||
| func (js *JSONSchema) Validate(message []byte) error { | |||
| return js.Decode(message, nil) | |||
| return nil | |||
There was a problem hiding this comment.
Schema.Validate method has never been called elsewhere before, but in actually, these methods will panic once they are called.
The second param cannot be nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1103
Motivation
Introduce
BooleanSchemaModifications
Add
BooleanSchemaVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation