Editor with Keyboard focus is not active TopComponent (undo/redo don't work while editing) #4437

errael · 2022-07-25T21:26:29Z

Apache NetBeans version

Apache NetBeans 14

What happened

I encountered this problem with the output window detached from the main NetBeans Window and focus-follows-mouse is set in the linux the window manager. While editing, I moved the mouse from editor to detached window, when the detached window gets focus the undo/redo buttons go inactive, move the mouse back to the editor and the buttons remain inactive although I can edit/save as usual.

How to reproduce

As described in What happened

Did this work correctly in an earlier version?

No / Don't know

Operating System

Linux harmony 5.18.10-76051810-generic #202207071639~~1657252310~~22.04~7d5e891 SMP PREEMPT_DYNAMIC Fri J x86_64 x86_64 x86_64 GNU/Linux

JDK

8,11,17

Apache NetBeans packaging

Own source build

Anything else

As a workaround, in a JEditorPane's focusListener.focusGained, I've essentially got:

    TopComponent tc = NbEditorUtilities.getOuterTopComponent(getEditor());
    if(tc != TopComponent.getRegistry().getActivated())
        tc.requestActive();

where getEditor() is like FocusEvent.getComponent().

For NetBeans, perhaps something like this

        Mode m = WindowManager.getDefault().findMode(tc);
        if(m != null)
            central.setActiveMode(m);

in MainWindow's windowListener (but without proper exerience in core.windows, I'd be hesitant to make changes in this area) or maybe a focus listener with something like the workaround I'm using above in an editor's TopComponent.

Relevant stack when moving mouse to detached window

	at org.netbeans.core.windows.WindowManagerImpl.notifyRegistryTopComponentActivated(WindowManagerImpl.java:1199)
	at org.netbeans.core.windows.Central.setActiveMode(Central.java:233)
	at org.netbeans.core.windows.Central.userActivatedModeWindow(Central.java:1883)
	at org.netbeans.core.windows.view.DefaultView.userActivatedModeWindow(DefaultView.java:654)
	at org.netbeans.core.windows.view.ui.DefaultSeparateContainer$SharedModeUIBaseImpl$1.windowActivated(DefaultSeparateContainer.java:455)
	at java.awt.AWTEventMulticaster.windowActivated(AWTEventMulticaster.java:398)

Are you willing to submit a pull request?

No

Code of Conduct

Yes

The text was updated successfully, but these errors were encountered:

mbien · 2022-07-26T12:17:18Z

i am not sure that this is a bug. Since other windows can have their own undo history. For example, even the ctrl+f combo box has a history.

Whatever has focus should listen to the undo events.

neilcsmith-net · 2022-07-26T13:33:29Z

Not sure this is about just undo, or specifically focus on hover. Try detaching a source editor tab into a separate window and Alt-TABing between. The cursor moves from one editor to the other, but the window system active tab doesn't change - undo/redo is wrong, navigator is wrong, and wrong tab is coloured as focused. Typing goes in the right place, though.

errael · 2022-07-26T15:02:50Z

Not sure this is about just undo, or specifically focus on hover

Right, the key is that the editor is not the active TopComponent. The description is just to point out that there's an issue, without getting into the weeds. Maybe: Editor with Keyboard focus is not active TopComponent is a good description. I didn't think to say that Ctrl-Z,Ctrl-Y stop working in the editor, that's probably better than talking about the buttons (but I never use those shortcuts).

An editor shortcut, "ActivateMe", could be used with the workaround code I showed.

errael · 2022-07-26T15:06:53Z

There are a lot of exceptions that come through org.netbeans.core.windows.FloatingWindowTransparencyManager, I don't know how general, platform independent, this exception issue is; it may not have anything to do with this problem report.

INFO [org.netbeans.core.nativeaccess.NativeWindowSystemImpl]
java.lang.UnsatisfiedLinkError: libjawt.so: cannot open shared object file: No such file or directory
	at com.sun.jna.Native.getWindowHandle0(Native Method)
	at com.sun.jna.Native$AWT.getComponentID(Native.java:2383)
	at com.sun.jna.Native.getComponentID(Native.java:326)
	at com.sun.jna.platform.WindowUtils$X11WindowUtils.getDrawable(WindowUtils.java:1747)
	at com.sun.jna.platform.WindowUtils$X11WindowUtils.access$900(WindowUtils.java:1564)
	at com.sun.jna.platform.WindowUtils$X11WindowUtils$2.run(WindowUtils.java:1769)
	at com.sun.jna.platform.WindowUtils$NativeWindowUtils.whenDisplayable(WindowUtils.java:398)
	at com.sun.jna.platform.WindowUtils$X11WindowUtils.setWindowAlpha(WindowUtils.java:1791)
	at com.sun.jna.platform.WindowUtils.setWindowAlpha(WindowUtils.java:1992)
[catch] at org.netbeans.core.nativeaccess.NativeWindowSystemImpl.setWindowAlpha(NativeWindowSystemImpl.java:91)
	at org.netbeans.core.windows.FloatingWindowTransparencyManager.turnTransparencyOff(FloatingWindowTransparencyManager.java:155)
	at org.netbeans.core.windows.FloatingWindowTransparencyManager.toggleFloatingWindowTransparency(FloatingWindowTransparencyManager.java:141)
	at org.netbeans.core.windows.FloatingWindowTransparencyManager.update(FloatingWindowTransparencyManager.java:96)
...

neilcsmith-net · 2022-07-26T15:14:03Z

@errael are you using Wayland? I think that might be separate issue.

Maybe: Editor with Keyboard focus is not active TopComponent is a good description.

Yes, probably better. That definitely seems like a valid issue to me.

errael · 2022-07-26T19:28:27Z

@neilcsmith-net

$ echo $XDG_SESSION_TYPE
x11

Not wayland; current System76/PopOS; gtk3
(Thought I'd already sent this)

neilcsmith-net · 2022-07-27T12:58:30Z

@errael I should have paid more attention - have seen issues with component ID on Wayland in the past, but the key thing is the UnsatisfiedLinkError. That's almost certainly caused by the issue fixed in java-native-access/jna#1422 I assume you might be running with distribution JDK? If so, it's definitely a separate issue.

errael · 2022-07-27T18:02:01Z

editor shortcut, "ActivateMe"

Ctrl-0 (SwitchToRecentDocumentAction) is a shortcut that does it. The code doesn't look right for a generic solution; which should probably be based on Listening to KeyboardFocusManager.

errael · 2022-07-27T18:27:32Z

@neilcsmith-net Thanks, (but I don't understand how the pieces fit together)

the key thing is the UnsatisfiedLinkError
...
I assume you might be running with distribution JDK?

Statement implies the fix goes into JDK; any idea which, if any, openjdk release has, or will have, it? Probably not important, but I'm curious if I'll see difference.

But wait, I see the jna jars in NetBeans...

Could NetBeans include jna with the fix? It's not in NB-15.
5.9.0 seems to be a year old. The fix you mentioned is in 5.11.0, end of March. The latest release, 5.12.1, is end of June.

$ jar -tvf netbeans-15-rc1-bin.zip | grep jna-
   433 Wed Jul 20 09:10:34 PDT 2022 netbeans/platform/config/Modules/org-netbeans-libs-jna-platform.xml
1729586 Wed Jul 20 09:10:34 PDT 2022 netbeans/platform/modules/ext/jna-5.9.0.jar
1343236 Wed Jul 20 09:10:34 PDT 2022 netbeans/platform/modules/ext/jna-platform-5.9.0.jar
 59224 Wed Jul 20 09:10:34 PDT 2022 netbeans/platform/modules/org-netbeans-libs-jna-platform.jar
   481 Wed Jul 20 09:10:34 PDT 2022 netbeans/platform/update_tracking/org-netbeans-libs-jna-platform.xml

neilcsmith-net · 2022-07-27T18:43:18Z

It's due to compilation and linking options used in certain JDK builds, particularly from various Linux distros, that cause older versions of JNA not to find libjawt. If you run on another JDK like Azul or Adoptium, you shouldn't see that error. Can you open another issue for that, though, including the stack trace? It's not triggering the main issue.

errael · 2022-07-27T19:21:27Z

Can you open another issue for that

Opened #4441

errael · 2022-07-28T15:32:25Z

When a mouse click is used to activate the top component, the stack is

    at org.netbeans.core.windows.WindowManagerImpl.notifyRegistryTopComponentActivated(WindowManagerImpl.java:1199)
    at org.netbeans.core.windows.Central.setActiveMode(Central.java:233)
    at org.netbeans.core.windows.Central.userActivatedMode(Central.java:1876)
    at org.netbeans.core.windows.view.DefaultView.userActivatedModeView(DefaultView.java:643)
    at org.netbeans.core.windows.view.ui.TabbedHandler$ActivationManager.handleActivation(TabbedHandler.java:524)
    at org.netbeans.core.windows.view.ui.TabbedHandler$ActivationManager.eventDispatched(TabbedHandler.java:471)
    at java.awt.Toolkit$SelectiveAWTEventListener.eventDispatched(Toolkit.java:2194)

I'm guessing a safe approach would be to use this same path when the activation should be done due to a focus change. The following change to org.netbeans.core.windows.view.ui.TabbedHandler seems to work in some extremely limited testing. Invoking handleActivation through the KeyboardFocusManager activates whatever TopComponenet gets keyboard focus; it should only occur when needed. For example, note that in the regular case of a mouse press that there is not a 2nd activation, the conditional test avoids invocation.

The change adds a KeyboardFocusManager propertyChangeListener to ActivationManager.

            if (activationManager == null) {
                activationManager = new ActivationManager();
                Toolkit.getDefaultToolkit().addAWTEventListener(
                    activationManager, AWTEvent.MOUSE_EVENT_MASK);
                KeyboardFocusManager.getCurrentKeyboardFocusManager()
                    .addPropertyChangeListener("focusOwner", activationManager);
            }
...
    private static class ActivationManager implements AWTEventListener, PropertyChangeListener {
        @Override
        public void eventDispatched(AWTEvent e) {
            if(e.getID() == MouseEvent.MOUSE_PRESSED) {
                System.err.println("ActivationManager: mouse: " + (e.getSource() == null ? null : e.getSource().getClass().getSimpleName()));
                handleActivation(e.getSource());
            }
        }

        @Override
        public void propertyChange(PropertyChangeEvent e) {
            Frame mainWindowNB = WindowManagerImpl.getInstance().getMainWindow();
            Window activeWindowKB = KeyboardFocusManager.getCurrentKeyboardFocusManager().getActiveWindow();
            TopComponent currentTC = TopComponent.getRegistry().getActivated();
            if(mainWindowNB == activeWindowKB
                    && mainWindowNB != SwingUtilities.getRoot(currentTC)) {
                System.err.println("ActivationManager: focus: " + (e.getNewValue() == null ? null : e.getNewValue().getClass().getSimpleName()));
                handleActivation(e.getNewValue());
            }
        }
...
        private void handleActivation(Object evtObject) {
            if (!(evtObject instanceof Component)) {
                return;
            }
            Component comp = (Component) evtObject;
...

errael · 2022-09-09T02:56:35Z

#4603 fixes this AFAICT.

errael · 2022-10-24T20:48:07Z

I was going to close this since #4603 is merged. But until it's released...

What's best practice for closing an issue?

errael · 2022-10-25T19:29:37Z

Fixed in NB16-RC1

errael added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Jul 25, 2022

errael changed the title ~~undo/redo buttons/actions dont' work while editing~~ undo/redo buttons/actions don't work while editing Jul 25, 2022

neilcsmith-net removed the needs:triage Requires attention from one of the committers label Jul 26, 2022

errael changed the title ~~undo/redo buttons/actions don't work while editing~~ Editor with Keyboard focus is not active TopComponent (undo/redo don't work while editing) Jul 26, 2022

errael mentioned this issue Jul 27, 2022

UnsatisfiedLinkError with detached window #4441

Closed

errael mentioned this issue Sep 9, 2022

Keyboard focus can activate top component #4603

Merged

errael closed this as completed Oct 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Editor with Keyboard focus is not active TopComponent (undo/redo don't work while editing) #4437

Editor with Keyboard focus is not active TopComponent (undo/redo don't work while editing) #4437

errael commented Jul 25, 2022

mbien commented Jul 26, 2022

neilcsmith-net commented Jul 26, 2022

errael commented Jul 26, 2022

errael commented Jul 26, 2022

neilcsmith-net commented Jul 26, 2022

errael commented Jul 26, 2022

neilcsmith-net commented Jul 27, 2022

errael commented Jul 27, 2022

errael commented Jul 27, 2022

neilcsmith-net commented Jul 27, 2022

errael commented Jul 27, 2022

errael commented Jul 28, 2022

errael commented Sep 9, 2022

errael commented Oct 24, 2022

errael commented Oct 25, 2022

Editor with Keyboard focus is not active TopComponent (undo/redo don't work while editing) #4437

Editor with Keyboard focus is not active TopComponent (undo/redo don't work while editing) #4437

Comments

errael commented Jul 25, 2022

Apache NetBeans version

What happened

How to reproduce

Did this work correctly in an earlier version?

Operating System

JDK

Apache NetBeans packaging

Anything else

Are you willing to submit a pull request?

Code of Conduct

mbien commented Jul 26, 2022

neilcsmith-net commented Jul 26, 2022

errael commented Jul 26, 2022

errael commented Jul 26, 2022

neilcsmith-net commented Jul 26, 2022

errael commented Jul 26, 2022

neilcsmith-net commented Jul 27, 2022

errael commented Jul 27, 2022

errael commented Jul 27, 2022

neilcsmith-net commented Jul 27, 2022

errael commented Jul 27, 2022

errael commented Jul 28, 2022

errael commented Sep 9, 2022

errael commented Oct 24, 2022

errael commented Oct 25, 2022