Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8.x][MNG-7349] Limit relocation warning message to direct dependencies only #657

Merged
merged 5 commits into from Jan 24, 2022

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jan 13, 2022

[MNG-7349] Superfluous relocation warning messages
@michael-o
Copy link
Member

michael-o commented Jan 13, 2022

If you plan to add an IT for that, I have recently added a test for relocated plugins and their config. You can reuse (copy) that and test it.

@gnodet gnodet changed the title [MNG-7349] Superfluous relocation warning messages [MNG-7349] Limit relocation warning message to direct dependencies only Jan 13, 2022
@gnodet gnodet changed the title [MNG-7349] Limit relocation warning message to direct dependencies only [3.8.x][MNG-7349] Limit relocation warning message to direct dependencies only Jan 17, 2022
@michael-o
Copy link
Member

Stupid question: Will it also apply to extensions?

@gnodet
Copy link
Contributor Author

gnodet commented Jan 17, 2022

Stupid question: Will it also apply to extensions?

Yes, both boot and build extensions use the DefaultPluginDependenciesResolver, so that should be fine.

@michael-o michael-o self-requested a review January 17, 2022 21:29
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is just fine, only the IT needs refinement then I am fine to squash and merge into master and maven-3.8.x.

@gnodet gnodet merged commit 83257bf into apache:maven-3.8.x Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants