Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6778] - Use https for maven schemaLocations #299

Merged
merged 1 commit into from Nov 9, 2019

Conversation

cwansart
Copy link
Contributor

@cwansart cwansart commented Nov 7, 2019

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.


This pull request changes the maven xsd urls from http to https according to https://issues.apache.org/jira/browse/MNG-6778. It does not change the urls for other xsds core-extension, settings, profiles, paramdoc, lifecycle, profiles, metadata and toolchains.

@cwansart
Copy link
Contributor Author

cwansart commented Nov 7, 2019

Still need to run core-its. done

@michael-o
Copy link
Member

Please note that parts of this work will be destroyed likely next time when the release plugin is run.

@cwansart
Copy link
Contributor Author

cwansart commented Nov 9, 2019

@michael-o why? I changed the schemaLocations in the maven.mdo so I thought then running the build it will simply re-create everything with the changed url?

@michael-o
Copy link
Member

I do remember that the Release Plugin rewrites the start tag. Previously, it injected still the old schema location. I may be wrong, but this needs to be checked.

@rfscholte
Copy link
Contributor

Just verified this: both master and 2.5.3 of maven-release-plugin doesn't change the schemaLocation if it is there.

@michael-o
Copy link
Member

Great, very good to know.

@rfscholte rfscholte merged commit d657c9c into apache:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants