New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] use utility method of Objects to simplify code #284
Conversation
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
Outdated
Show resolved
Hide resolved
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not use star import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olamy thanks for review.I have modified the code as your suggestion.
import java.util.Map; | ||
import java.util.Properties; | ||
import java.util.Set; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not use star import
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Set; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not use star import
import java.util.Iterator; | ||
import java.util.Map; | ||
import java.util.Properties; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not use star import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ezy changes with simplified code
@caidezhi next time please run |
@rfscholte I am sorry that the pull request cause some inconveniences (forget that my IDEA setting is "-Dcheckstyle.skip=true"). I will follow the process in future. Many thanks for your help. |
use utility method ( Objects.equals ) to rewrite some equals logic in code base.