Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6713] Fix ExclusionArtifactFilter to respect wildcard exclusions. #269

Merged
merged 2 commits into from Aug 6, 2019

Conversation

saturnism
Copy link
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
What about adding a constant for '*' ?

@michael-o
Copy link
Member

@saturnism Can you change the code as requested by @eolivelli?

@rfscholte rfscholte merged commit 8a1f572 into apache:master Aug 6, 2019
@Tibor17
Copy link
Contributor

Tibor17 commented Aug 7, 2019

@michael-o
@olamy
@eolivelli
@rfscholte
After Robert merged the comit to remote master, the build failed with strange issue on sockets.
Where these sockets come from? The MRM plugin?
https://builds.apache.org/job/maven-box/job/maven/job/master/269/testReport/junit/org.apache.maven.it/MavenITmng4554PluginPrefixMappingUpdateTest/windows_jdk12___Run_ITs_Windows_Java_12___testitCached/
Do you check also the Jenkins/master after pushed to master?

@rfscholte
Copy link
Contributor

Of course I check master and I get notifications. The commit succeeded as a branch.
Based on the error it is very unlikely it is a Windows + JDK12 issue. I'll give it another try.

@Tibor17
Copy link
Contributor

Tibor17 commented Aug 7, 2019

@rfscholte
I doubt about running the build again should be the right way to make the build passed because it looks like there is no repo on server socket on localhost:80. The question is where this come from.
Could not transfer metadata org.apache.maven.its.mng4554/maven-metadata.xml from/to central (http://localhost:-1/repo-1): Connect to localhost:80 [localhost/127.0.0.1, localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connect

@Tibor17
Copy link
Contributor

Tibor17 commented Aug 7, 2019

@rfscholte
I have fixed the build 269. The error is mentioned in JavaDoc

    /**
     * @return The actual port the connector is listening on or -1 if there 
     * is no port or the connector is not open.
     */
    int getLocalPort();

apache/maven-integration-testing@482756e

asfgit pushed a commit that referenced this pull request Aug 24, 2019
#269)

* [MNG-6713] Fix ExclusionArtifactFilter to respect wildcard exclusions.

* Moved `*` to a constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants