MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependencies() #193
Conversation
mickaelistria
changed the title
|
@slachiewicz Is there anything else I should do to influence this to get in 3.6.1 (and even a 3.5.4 if possible)? |
| @@ -30,7 +32,8 @@ | |||
| public class ProjectBuilderTest | |||
| extends AbstractCoreMavenComponentTestCase | |||
| { | |||
| protected String getProjectsDirectory() | |||
| @Override | |||
| protected String getProjectsDirectory() | |||
| MavenSession mavenSession = createMavenSession( null ); | ||
| ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest(); | ||
| configuration.setRepositorySession( mavenSession.getRepositorySession() ); | ||
| configuration.setResolveDependencies(true); |
There was a problem hiding this comment.
Can we add a test in which this is false and assert that resolution actually does not happen ?
|
Do you prefer an extra commit or should I squash them all in a single one? |
|
squash please |
|
notice I updated the code in the branch |
mickaelistria
force-pushed
the
MNG-6529-test
branch
from
bb58484
to
501e2d8
Compare
|
Squashed, whitespace issue fixed, extra test added for |
| @@ -84,4 +87,39 @@ public void testVersionlessManagedDependency() | |||
| // this is expected | |||
| } | |||
| } | |||
|
|
|||
| public void testResolveDependencies() throws Exception { | |||
There was a problem hiding this comment.
please format unit tests with common style: this will improve maintenance
|
notice that the commit message should use the right method name: isResolveDependencies(), instead of isResolvedDependency() |
hboutemy
changed the title
request.isResolveDependency
mickaelistria
force-pushed
the
MNG-6529-test
branch
from
501e2d8
to
732e7de
Compare
|
@hboutemy Thanks, I updated the change according to your comments (I could have missed some style stuff though). |
|
sorry, I completely overlooked your answer |
Fix FlattenMojoTest on Windows
This adds a (failing) unit test showcasing that ProjectBuilder.build(List projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies().
And then it adds a fix that turns the test green.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.