Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-6302] logging the module count #136

Merged
merged 1 commit into from Nov 19, 2017
Merged

[MNG-6302] logging the module count #136

merged 1 commit into from Nov 19, 2017

Conversation

rmannibucau
Copy link
Contributor

Idea is to let the user identify how many modules are still to be executed/processed

@michael-o
Copy link
Member

Looks good to me.

@stephenc
Copy link
Contributor

stephenc commented Nov 9, 2017

👍

aheritier
aheritier approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hboutemy
Copy link
Member

merged as a branch in Maven git https://github.com/apache/maven/tree/MNG-6302_module-progress
and reworked to avoid additional line "Module i/n" but have instead integrated at the end of "Building" line:

[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Maven Distribution 3.5.3-SNAPSHOT                [15/15]
[INFO] ------------------------------------------------------------------------

@michael-o
Copy link
Member

@hboutemy Tested your branch. Great improvement to the PR! +1

@asfgit asfgit merged commit 4d49d3b into apache:master Nov 19, 2017
pzygielo pushed a commit to pzygielo/maven that referenced this pull request Jan 4, 2023
@olamy
fix apache#136 use https in pom file as it is now done in maven 3.6.3…
49e81a9 
… and so update travis etc bump parent pom so we can now use 1.7 (apache#137)

* fix apache#136 use https in pom file as it is now done in maven 3.6.3 and so update travis etc... bump parent pom so we can now use 1.7

Signed-off-by: olivier lamy <olamy@apache.org>

* switch to openjdk 8 and 11

Signed-off-by: olivier lamy <olamy@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheritier aheritier aheritier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@rmannibucau @michael-o @stephenc @hboutemy @aheritier @asfgit