Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9.x][MNG-7608] Make native transport the default #961

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jan 17, 2023

This immediately cuts in "half" the count of HTTP requests against Maven Central or any major MRM.

Altering the meaning of "default": is now semantically same as "auto", but still leaving it in place for future, as "default" at some point may again become something different than "native". This change is exactly same as happened in Maven 4.x and transports are aligned now.


https://issues.apache.org/jira/browse/MNG-7608

This immediately cuts in "half" the count of HTTP requests against Maven Central or any major MRM.

Altering the meaning of "default": is now same as "auto", but still leaving it in place for future, as "default" at some point may again become something different than "native".

---

https://issues.apache.org/jira/browse/MNG-7608
@cstamas cstamas self-assigned this Jan 17, 2023
@cstamas cstamas marked this pull request as ready for review January 17, 2023 07:12
@cstamas
Copy link
Member Author

cstamas commented Jan 17, 2023

This change breaks one IT MavenITmng7470ResolverTransportTest.testResolverTransportDefault as it alters default transport, IT is adjusted in apache/maven-integration-testing#237

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection here and progress output looks just like before, but with the release notes there must a s pecial note that the transport has changed and people must know exactly about it.

@cstamas cstamas changed the title [MNG-7608] Make native transport the default [3.9.x][MNG-7608] Make native transport the default Jan 17, 2023
@cstamas cstamas merged commit f7ca0b6 into apache:maven-3.9.x Jan 17, 2023
@cstamas cstamas deleted the MNG-7608-default-transport branch January 17, 2023 09:08
@cstamas cstamas added this to the 3.9.0 milestone Jan 25, 2023
@gnodet gnodet mentioned this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants