Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2051] Propagate exceptions while resolving artifacts in SurefireDependencyResolver #504

Merged
merged 1 commit into from Mar 30, 2022
Merged

[SUREFIRE-2051] Propagate exceptions while resolving artifacts in SurefireDependencyResolver #504

merged 1 commit into from Mar 30, 2022

Conversation

hisener
Copy link
Contributor

@hisener hisener commented Mar 29, 2022

Surefire doesn't propagate the exception during artifact resolution, and then later, it fails with a NullPointerException when it needs to access the artifact (in AbstractSurefireMojo.java#L4125 or SurefireDependencyResolver.java#L203). This makes harder to understand the underlying issue. This change uses ResolutionErrorHandler to propagate the actual issue.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Tibor17 Tibor17 self-requested a review March 29, 2022 23:54
@Tibor17
Copy link
Contributor

Tibor17 commented Mar 29, 2022

Right on the time!
We are about to cut the release.
Pls make requested updates.

@slawekjaranowski
Copy link
Member

@Tibor17 I propose postpone cosmetic changes, for next PR.
After have build pass I will merge it.

@slawekjaranowski
Copy link
Member

@hisener thanks for contribution

@Tibor17
Copy link
Contributor

Tibor17 commented Mar 30, 2022

@Tibor17 I propose postpone cosmetic changes, for next PR. After have build pass I will merge it.

@slawekjaranowski which one?

@Tibor17
Copy link
Contributor

Tibor17 commented Mar 30, 2022

@slawekjaranowski
Thx for taking care of the PRs #500 and #504 . Pls complete them after successful build.
I would, meanwhile build the site and I will check the page in browser if there are any visual issues. Feel free to check the site too.

@Tibor17
Copy link
Contributor

Tibor17 commented Mar 30, 2022

@hisener
Pls squash both commits.

@hisener
Copy link
Contributor Author

hisener commented Mar 30, 2022

Sorry, I am seeing this just now. I'll do that. :loading:

@Tibor17
Copy link
Contributor

Tibor17 commented Mar 30, 2022

@hisener
Thx for contributing! Feel free to participate on the development in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants