Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-1432] trimStackTrace = false by default #502

Merged
merged 1 commit into from Mar 29, 2022
Merged

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Mar 27, 2022

A simple change in the behavior, by user group request, changing the default value for trimStackTrace from true to false.

Backporting the improvement SUREFIRE-1432 (8a6b334) from the branch origin/release/3.0.0-M6 to origin/master.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I can't found classes StackTraceInterpreterExtension, DefaultStackTraceImpl,SmartStackTraceImpl mentioned in issue in project.

Does description in issue is one for this change?

@Tibor17
Copy link
Contributor Author

Tibor17 commented Mar 29, 2022

@slawekjaranowski
I think I took over the description by some user.
Now we use SmartStackTraceParser everywhere except the JUnit3 provider. Currently, the logic is located in the class EventChannelEncoder.StackTrace and the event sticks to boolean trimStackTraces which comes from MOJO config.
Probably SmartStackTraceParser#writeTraceToString() is DefaultStackTraceImpl, and SmartStackTraceParser#writeTrimmedTraceToString() is SmartStackTraceImpl.
I think the historycal code had two classes and DefaultXXX but I hardly remember. Maybe the Git history shows more.
We can rewrite the description because it does not match the #203 from the contributor.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Mar 29, 2022

@slawekjaranowski
I have cleaned up the release backlog and there is only this issue with the status - reopened. The rest of the tickets are closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants