Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2046] Resolved TODOs. Updated callbacks ForkedProcessPropertyEventListener and ForkedProcessStandardOutErrEventListener. #501

Merged
merged 1 commit into from Mar 27, 2022

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Mar 26, 2022

The issue is SUREFIRE-1860 is a parent 6 child issues.
I forgot to update two listeners out of three which belong to handlers of test specifics.
ForkedProcessReportEventListener was updated in SUREFIRE-2014 but the other two (ForkedProcessPropertyEventListener and ForkedProcessStandardOutErrEventListener) were missed.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Mar 26, 2022

@slawekjaranowski
Pls read the description. There is explanation.
It should be a fast review because we added the parameter testRunId which we were aiming for in SUREFIRE-1860.
The TestSetRunListener will consume additional information RunMode and testRunId. Currently, it is not the case.

…tyEventListener and ForkedProcessStandardOutErrEventListener.
@Tibor17
Copy link
Contributor Author

Tibor17 commented Mar 27, 2022

@slawekjaranowski
I have fixed the previous commit - NPE by autoboxing: long to Long

@Tibor17 Tibor17 merged commit db99f16 into master Mar 27, 2022
@Tibor17 Tibor17 deleted the SUREFIRE-2046 branch March 27, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants