Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-1964] Support for method filtering on excludesFile and includesFile #490

Merged
merged 2 commits into from Mar 17, 2022

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Mar 14, 2022

The purpose of this PR is to add the authors.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Tibor17 and others added 2 commits March 14, 2022 21:58
…udesFile

committers: Ildefonso Montero, Tibor Digaňa
Add the implementation and integration tests
Add some unit tests
Add some javadoc to includesFile and excludesFile
@Tibor17
Copy link
Contributor Author

Tibor17 commented Mar 14, 2022

@imonteroperez
Feel free to participate.
See the Git metadata and the git commit message.

@hboutemy
Copy link
Member

@imonteroperez please review and confirm it is ok for you
the fact that you are not in the list of reviewers is just because we can't add you...

Copy link
Contributor

@imonteroperez imonteroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tibor17
Copy link
Contributor Author

Tibor17 commented Mar 16, 2022

@imonteroperez
yes, exactly, I could not add your name to the reviewers because the combobox box provides only ASF staff. So I had only one option to ping you directly in the first message.
Let's wait for the colleagues.

@olamy
Copy link
Member

olamy commented Mar 17, 2022

LGTM

as long as @imonteroperez is happy with that I'm happy too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants