New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUREFIRE-2026] Improve assertions in Surefire1787JUnit5IT #474
Conversation
.verifyErrorFreeLog(); | ||
.verifyErrorFree( 1 ) | ||
.verifyTextInLog( "Running pkg.JUnit5Tests" ) | ||
.verifyTextInLog( "Using auto detected provider org.apache.maven.surefire.junit4.JUnit4Provider" ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JUnit4Provider
is the actual status with the bug in ASM.
It should be JUnitPlatformProvider
after the final fix. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok IMHO. When we want Junit5 test using Junit4 we add junit-platform-runner as a dependency.
https://junit.org/junit5/docs/current/user-guide/#running-tests-junit-platform-runner
@slawekjaranowski |
@slawekjaranowski private Artifact getJUnit5Artifact()
{
Artifact artifact = getPluginArtifactMap().get( "org.junit.platform:junit-platform-engine" );
if ( artifact == null )
{
artifact = getProjectArtifactMap().get( "org.junit.platform:junit-platform-runner" );
}
if ( artifact == null )
{
return getProjectArtifactMap().get( "org.junit.platform:junit-platform-commons" );
}
return artifact;
} |
@Tibor17 |
5066038
to
5f79702
Compare
new issue was created, and PR updated. |
@slawekjaranowski |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
SUREFIRE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean install
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.