[SUREFIRE-2016] The MOJO parameter testSourceDirectory is used only in the TestNG HTML, and it should be optional. Javadoc and documentation should be fixed. #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -281,10 +281,11 @@ | |||
|
|
|||
| /** | |||
| * The test source directory containing test class sources. | |||
| * Important for TestNG HTML reports. | |||
There was a problem hiding this comment.
please add that only for ... and maybe bold/italic such sentence
There was a problem hiding this comment.
I wanted to initially do write so :-)
There was a problem hiding this comment.
@slawekjaranowski
done, pls check it again
Tibor17
force-pushed
the
SUREFIRE-2016
branch
from
6101fc3
to
4b85c85
Compare
…n the TestNG HTML, and it should be optional. Javadoc and documentation should be fixed.
Tibor17
force-pushed
the
SUREFIRE-2016
branch
from
4b85c85
to
5b7b9b4
Compare
slawekjaranowski
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MOJO param
testSourceDirectoryis currently required.It is maybe a history. But now this parameter has no real meaning. One of our users in SUREFIRE-2013 was confused with that and he thought that this param is used for some test filters. Not true because it is used only in the TestNG HTML reports and nowhere else.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
SUREFIRE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.