[SUREFIRE-2012] Use maven-shared-utils instead of surefire-shared-utils in Report Parser. Removed commons-lang in Report Plugin.

[Tibor17]

Following this checklist to help us incorporate your
contribution quickly and easily:

• [x ] Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• [x ] Each commit in the pull request should have a meaningful subject line and body.
• [x ] Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• [x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean install to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• [ x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[Tibor17]

@slawekjaranowski
surefire-shared-utils is not necessary in the Report plugin. Using maven-shared-utils instead.

[slawekjaranowski]

great - I dream about removing surefire-shared-utils (maven-shared-utils) at all 😃

[slawekjaranowski]

is indentation correct ... looks like change from 2 -> 4 space?

[Tibor17]

4 is correct
I am using Maven profile in IDEA.

[Tibor17]

@slawekjaranowski
But maven-shared-utils has CLI class, platform specific impl. We need it. Other classes are minor. If we could extract only that as sources and not bytecode, and if we substituted DirectoryScanner with NIO Files, then yes, it would be possible to get right of shaded classes.

[Tibor17]

There is not much methods and classes we use, we can write our own, few util methods. The problem is with CLI.

[slawekjaranowski]

https://maven.apache.org/developers/conventions/code.html
https://maven.apache.org/developers/maven-idea-codestyle.xml

4 - for java
2 - for xml

[slawekjaranowski]

I thought about surefire-shared-utils not maven-shared-utils ...

I now there are place where we must shade package from maven-shared-utils and other but I hope it can be done in the last module in the tree where maven-shared-utils is used ... but it is another story

[Tibor17]

@slawekjaranowski
We shade the maven-shared-utils into surefire-shared-utils, and much more.
I can imaging the dependency maven-shared-utils with type sources extracting CLI classes to generated sources, and adding new DirectoryScanner based on NIO in src/main/java. This can be done but you need to have a spare time to write unit tests for the scaner and several trivial utility methods.

[Tibor17]

@slawekjaranowski
Anyway, the class org.apache.maven.shared.utils.io.DirectoryScanner is deprecated in m-shared-u. It can be substituted by java.nio.file.DirectoryStream. We should use our own scanner class.

[Tibor17]

@slawekjaranowski
Pls check it now. The codestyle XML did not make the trick. The problem was with .editorconfig.