Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2003] Upgrade Maven Reporting to 3.1.0 #464

Merged
merged 1 commit into from Feb 14, 2022
Merged

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Feb 9, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • [x ] Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • [ x] Each commit in the pull request should have a meaningful subject line and body.
  • [x ] Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • [x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x ] Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski
Copy link
Member

Failed IT test .... Surefire1490ReportTitleDescriptionIT
with:

Error injecting: org.apache.maven.plugins.surefire.report.SurefireReportOnlyMojo
java.lang.NoClassDefFoundError: org/apache/maven/doxia/siterenderer/DocumentContent

@Tibor17
Copy link
Contributor Author

Tibor17 commented Feb 10, 2022

@slawekjaranowski
Yes, I saw this error too.
How can we fix this?

@slawekjaranowski
Copy link
Member

Probably conflict with doxia version.

I will try to remove exclusions
https://github.com/apache/maven-surefire/blob/master/maven-surefire-report-plugin/pom.xml#L73-L90

and all added doxia artifacts dependency

@Tibor17
Copy link
Contributor Author

Tibor17 commented Feb 10, 2022

Not necessary because they already exist, see the Line 92 - 107.
https://github.com/apache/maven-surefire/blob/master/maven-surefire-report-plugin/pom.xml#L92-L107

@slawekjaranowski
Copy link
Member

I will remove exclusions and line 92 - 107
and let maven-reporting-impl to take dependencies which needed

@Tibor17
Copy link
Contributor Author

Tibor17 commented Feb 11, 2022

@slawekjaranowski
Feel free to use this branch.

Comment on lines +46 to +54
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
<version>3.10.0</version>
</plugin>
</plugins>
</pluginManagement>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a root cause ... old maven-site-plugin

@slawekjaranowski
Copy link
Member

@Tibor17 fixed

@Tibor17
Copy link
Contributor Author

Tibor17 commented Feb 14, 2022

@slawekjaranowski
Thx, I want to make one a little change or improvement. Let;s see the CI result.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Feb 14, 2022

@slawekjaranowski
The build is successful except for one which lost the connection with Maven repo - https://repo.maven.apache.org:443 https://repo.maven.apache.org/: Connection timed out. Count not download Junit5 librraies - not related to this PR.

@Tibor17 Tibor17 merged commit e8ac9b6 into master Feb 14, 2022
@Tibor17 Tibor17 deleted the SUREFIRE-2003 branch February 14, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants