Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-1556] Test XML file is not valid when rerun "fails" with an assumption #450

Merged
merged 1 commit into from Feb 2, 2022

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Jan 28, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Jan 28, 2022

Hi @Micky002

Finally, we will avoid the bug. The ideal situation would be to introduce a new XML element rerunAssumption but this would require us to create a new XSD schema and a new version. Making this just for one bug fix would be stresful for all frameworks of test reports e.g. in the Jenkins community.
So I have created a new issue SUREFIRE-1986 and we may have a chance to include more requirements in the version 3.1.
This fix will be backported to the plugin version 2.22.3 as well.

@Tibor17 Tibor17 merged commit 47aebbb into master Feb 2, 2022
@Tibor17 Tibor17 deleted the SUREFIRE-1556 branch February 2, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant