Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-1937] [SUREFIRE-1938] [SUREFIRE-1980] [SUREFIRE-1981] #444

Merged
merged 4 commits into from Jan 19, 2022

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Jan 18, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski
Copy link
Member

When one PR contains many updates we don't sure which one is cause to build failure ...

@Tibor17
Copy link
Contributor Author

Tibor17 commented Jan 18, 2022

@slawekjaranowski
I am sure because I can see the logs, code and we developers are great in analysis and investigation. Yes, many devs just say, there is a bug but they do not see any log, any files, any analysis, nothing. And it happens many times and in many companies and that's really pity. Of course I am testing every commit on my side.
This issue was very simple to understand, the maven-shared-utils has CLI API which is platform specific and escapes the CLI arguments, especially on *Nix systems, more specifically classes BourneShell and CmdShell and that's the reason why my local tests passed on Windows.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Jan 18, 2022

Surefire1367AssumptionLogsIT fails due to XML marshaller has changed. The marshaller is called in StatelessXmlReporter and this IT which has failed is about checking the string contained in XML. The XML marshaller is only in maven-shared-utils and nowhere else.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tibor17 Tibor17 merged commit 2da8f9b into master Jan 19, 2022
@Tibor17 Tibor17 deleted the ext-libs branch January 19, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants