Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Shared Action v2 #425

Merged
merged 1 commit into from Jan 4, 2022
Merged

GitHub Shared Action v2 #425

merged 1 commit into from Jan 4, 2022

Conversation

slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Tibor17
Copy link
Contributor

Tibor17 commented Jan 2, 2022

Two checks 1, 2 were skipped. Can you please have a look what happened there? Thx

@Tibor17
Copy link
Contributor

Tibor17 commented Jan 2, 2022

Here are 10 parallel builds and they do not fail. So the disk capacity 14GB is enough here. But if we employed more h/w or jdk versions making 20 builds again, some verification may crash again on low disk space.

@Tibor17
Copy link
Contributor

Tibor17 commented Jan 2, 2022

Is it possible to assign a timeout to each individual verification run? So that we can prevent from scenarios where the issue exhausted all resources ASF was given by GH?

@slawekjaranowski
Copy link
Member Author

Check 1,2 are skipped because was triggered for pull_request event, and PR is from local branch from repo so build on branch push will be enough.

@slawekjaranowski
Copy link
Member Author

I think that each job is executed on separate vm with separate disk space.

@slawekjaranowski
Copy link
Member Author

time out will be in next PR, first must be added to shared action as options

@Tibor17
Copy link
Contributor

Tibor17 commented Jan 2, 2022

@slawekjaranowski
I have found something interesting, see this.
By default, public shared Github runners come with around 25-29 GB of free disk space to be consumed by your build job. Even if VM reserved 14 GB on SSD, the entire job has its own limits and this is maybe the reason why we reached the limits. We can maximize available disk space for our build tasks, see this step extension and feel free to discus it with ASF colleagues. What you think about this step extension?
If we employ more Java versions or Maven versions and platforms we may run out of disk space again.

One of our ASF colleagues says that you can free up a bit of space by cleaning these dirs:

sudo rm -rf /usr/local/lib/android # will release about 10 GB if you don't need Android
sudo rm -rf /usr/share/dotnet # will release about 20GB if you don't need .NET

@slawekjaranowski
Copy link
Member Author

ok, everything can be add to shared action so other project can also have the same benefits.

@slawekjaranowski slawekjaranowski merged commit 2a97a4c into master Jan 4, 2022
@slawekjaranowski slawekjaranowski deleted the gh-shared-v2 branch January 4, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants