[SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release #422

Tibor17 · 2022-01-01T00:20:33Z

Following this checklist to help us incorporate your
contribution quickly and easily:

Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run mvn clean install to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

slawekjaranowski · 2022-01-01T13:16:32Z

...roviders/surefire-junit3/src/test/java/org/apache/maven/surefire/junit/JUnitTestSetTest.java

 import org.apache.maven.surefire.common.junit3.JUnit3Reflector;
 import org.apache.maven.surefire.api.report.ReportEntry;
 import org.apache.maven.surefire.api.report.RunListener;
 import org.apache.maven.surefire.api.report.RunMode;
 import org.apache.maven.surefire.api.report.TestSetReportEntry;
+import org.apache.maven.surefire.shared.lang3.JavaVersion;


In test classes we can use direct comons - not shaded

@slawekjaranowski
It has certain purpose.

slawekjaranowski · 2022-01-01T13:18:38Z

...roviders/surefire-junit3/src/test/java/org/apache/maven/surefire/junit/JUnitTestSetTest.java

+                fail();
+            }
+
+            Object sm = invokeGetter( System.class, null, "getSecurityManager" );


System.getSecurityManager() is public ... why by reflections

slawekjaranowski · 2022-01-01T13:25:21Z

surefire-api/src/main/java/org/apache/maven/surefire/api/util/internal/ObjectUtils.java

+    public static boolean isSecurityManagerSupported()
+    {
+        ClassLoader classLoader = ObjectUtils.class.getClassLoader();
+        Class<?> smClass = tryLoadClass( classLoader, "java.lang.SecurityManager" );
+        return smClass != null && !smClass.isAnnotationPresent( Deprecated.class );
+    }


Is checking java version >= 17 not enough?

It was my previous solution but the class appears in module surefire-booter. This is surefire-api, so we cannot inherit it and cannot duplicate the code.

what about Java Version from commons lang3 is is accessible by org.apache.maven.surefire.shared.lang3.JavaVersion

@slawekjaranowski
Now JavaVersion is in use!

slawekjaranowski · 2022-01-01T15:06:39Z

.github/workflows/maven-verify.yml

+    timeout-minutes: 120
+    steps:
+    - name: Verify
+      uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1


it is shared workflow ... can not be uses as step

We can extend this workflow with artifacts upload support

@slawekjaranowski
This change does not exit in this branch any longer.

Tibor17 · 2022-01-01T15:07:58Z

This CI script will publish archived artifacts for further analysis. We need to find out why the JVM exists after one hour of execution.

slawekjaranowski · 2022-01-01T15:11:32Z

.github/workflows/maven-verify.yml

+
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macOS-latest]
+        java: [8, 11, 17]
+        jdk: [temurin]
+      fail-fast: false
+
+    runs-on: ${{ matrix.os }}
+    timeout-minutes: 120
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v1
+
+      - name: Set up JDK ${{ matrix.java }}
+        uses: actions/setup-java@v2.4.0
+        with:
+          distribution: ${{ matrix.jdk }}
+          java-version: ${{ matrix.java }}
+          cache: 'maven'
+
+      - name: Build with Maven
+        run: mvn clean install -e -B -V -nsu --no-transfer-progress -P run-its -Dfailsafe-integration-test-port=8083
+
+      - name: Upload artifact surefire-its
+        uses: actions/upload-artifact@v2-preview
+        if: failure()
+        with:
+          name: ${{ matrix.os }}-surefire-its
+          path: |
+            surefire-its/target/*/log.txt
+            surefire-its/target/**/surefire-reports/*
+            surefire-its/target/**/failsafe-reports/*
+            !surefire-its/target/failsafe-reports


Don't do it in this way
it is step backward

The commit message is investigating. The commit does not mean anything for this Jira issue. We are discussing the timeout in the Slack/INFRA channel and I need to get the archive of surefire-its/target with all the dump files and logs. This was happening one year ago and I came over this problem by splitting the test set in two. Currently I am waiting for the build to complete and I hope the archive files would appear in the attachment. Then I want to go inside and analyse the logs and test content.

@slawekjaranowski
The build runs every configuration twice, means push and pull_request. This is the waste and I also could not avoid it in my scripts. Do you know how to do it? This would save the h/w resources in favor of others.

That is because we have two events:

push to branches

pull_request

I try to discover how prevent it

by the way attached artifacts has size > 1GB ...

@slawekjaranowski
This change does not exit in this branch any longer.

Tibor17 · 2022-01-01T17:57:51Z

This investigation has helped me.

It looks like the GH build runs out of disk space.
I made a ZIP of the largest sub-module and its target folder occupies 1.2GB and I deleted binary files. So the real consumption of the disk space must be much bigger.
The problem is that the ZIP does not contain the logs of the last 40 integration test however they were executed but their files are no more on the disk! Still we are somewhere in the middle of the entire test set.
How can we prove my hypothesis other way that the particular build runs out of disk space?

It looks like one build crashed but the other did not.

Tibor17 · 2022-01-01T23:46:17Z

@slawekjaranowski
One of our colleagues told me that the Github CI reserves 14GB of disk space. Maybe the problem is that we execute 20 parallel builds. We should try to avoid the duplicates (push, pull_request) which makes 1.4GB per each run configuration. I would propose to additionally overriding the Java version with min and max, means 8 and 17 only, if 10 parallel builds still does not help.

…e removed in a future release

Tibor17 force-pushed the SUREFIRE-1975 branch from ba44457 to 4770f5f Compare January 1, 2022 00:38

slawekjaranowski reviewed Jan 1, 2022

View reviewed changes

slawekjaranowski requested changes Jan 1, 2022

View reviewed changes

This was referenced Jan 2, 2022

Surefire shared utils, #424

Closed

[SUREFIRE-1972] Use current version of surefire-shared-utils #426

Closed

Tibor17 force-pushed the SUREFIRE-1975 branch from 089f18f to 3cfc32d Compare January 19, 2022 20:47

Tibor17 requested review from eolivelli and slachiewicz January 20, 2022 00:06

Tibor17 force-pushed the SUREFIRE-1975 branch 4 times, most recently from 1dead69 to 7aea773 Compare January 21, 2022 00:02

[SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will b…

0953f57

…e removed in a future release

Tibor17 force-pushed the SUREFIRE-1975 branch from 7aea773 to 0953f57 Compare January 21, 2022 00:19

Tibor17 merged commit aeb6a32 into master Jan 21, 2022

Tibor17 deleted the SUREFIRE-1975 branch January 21, 2022 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release #422

[SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release #422

Tibor17 commented Jan 1, 2022

slawekjaranowski Jan 1, 2022

Tibor17 Jan 19, 2022

slawekjaranowski Jan 1, 2022

slawekjaranowski Jan 1, 2022

Tibor17 Jan 1, 2022

slawekjaranowski Jan 1, 2022

Tibor17 Jan 19, 2022

slawekjaranowski Jan 1, 2022

slawekjaranowski Jan 1, 2022

Tibor17 Jan 19, 2022

Tibor17 commented Jan 1, 2022

slawekjaranowski Jan 1, 2022

Tibor17 Jan 1, 2022 •

edited

Tibor17 Jan 1, 2022

slawekjaranowski Jan 1, 2022

slawekjaranowski Jan 1, 2022

Tibor17 Jan 19, 2022

Tibor17 commented Jan 1, 2022 •

edited

Tibor17 commented Jan 1, 2022 •

edited

[SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release #422

[SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release #422

Conversation

Tibor17 commented Jan 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tibor17 commented Jan 1, 2022

Choose a reason for hiding this comment

Tibor17 Jan 1, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tibor17 commented Jan 1, 2022 • edited

Tibor17 commented Jan 1, 2022 • edited

Tibor17 Jan 1, 2022 •

edited

Tibor17 commented Jan 1, 2022 •

edited

Tibor17 commented Jan 1, 2022 •

edited