From 61ebc8e0d29c946a71ae90fd7b1acbe4d55a597d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yoann=20Rodi=C3=A8re?= Date: Mon, 4 Apr 2022 11:58:24 +0200 Subject: [PATCH] [SUREFIRE-2056] Fix buffer overflow in EventChannelEncoder when the test ID is null --- .../apache/maven/surefire/booter/spi/EventChannelEncoder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java index b4a234d490..dbc3d52f43 100644 --- a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java +++ b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java @@ -393,7 +393,7 @@ ByteBuffer encodeMessage( ForkedProcessEventType eventType, RunMode runMode, Lon { CharsetEncoder encoder = newCharsetEncoder(); int bufferMaxLength = estimateBufferLength( eventType.getOpcode().length(), runMode, encoder, 0, - testRunId == null ? 0 : 1, message ); + 1, message ); ByteBuffer result = ByteBuffer.allocate( bufferMaxLength ); encode( encoder, result, eventType, runMode, testRunId, message ); return result;